<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103856/">http://git.reviewboard.kde.org/r/103856/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just tried it and it works perfectly. Just commit it and we'll fix any problems that come up.
One thing though: from my experience you should be very careful with hackish things in Qt ItemModels. They interact with the view in complex, non-transparent ways that are even subject to change in the future. Those regressions are the worst to debug.</pre>
<br />
<p>- Bart</p>
<br />
<p>On February 3rd, 2012, 11:58 a.m., Matěj Laitl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Bart Cerneels.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2012, 11:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another approach to fix bug 291068, be more permissive
Bart originally solved the bug by enabling track dropping only
precisely on root collection rows. This is IMO too much restrictive
as it prevents you to drag tracks between 2 large expanded collections
without excessive scrolling. (something I would miss) Additionally,
there was no visual indication that the drop will not be performed.
This is my try to rework it in a way that:
* keeps drops onto artists/albums (whatever you first level
entity in collection browser is) allowed. There is a drop indicator
that clearly shows that the drop will go _between_ the entities, not
to them.
* disables drops to read-only collections
* disabled drops are indicated visually using the not-allowed mouse
cursor (the tricky part, but commented well in code)
BUG: 291068</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as described here.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=291068">291068</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(ed4e955deeebf6a506e87ca8973645b9eeadc67b)</span></li>
<li>src/browsers/CollectionTreeItemModel.cpp <span style="color: grey">(d2bab082f44b37fa8945c827006439e7deb0017e)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.h <span style="color: grey">(c6cca46fff956f9123299cb29c81e6a792abbc3b)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(e7f8e620a0ae2f7546c879dfd5d67a13fcb0f34a)</span></li>
<li>src/browsers/CollectionTreeView.h <span style="color: grey">(b70f99d811d1f7f271ec79298c3b0140fbd0ede4)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: grey">(c9069c770fd28fe16e76b1af132f3c7dff4c82d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103856/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>