<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103871/">http://git.reviewboard.kde.org/r/103871/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3788b0ee6d6407c1b459b16181d32db247aedcaf by Matěj Laitl to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 5th, 2012, 11:56 a.m., Matěj Laitl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2012, 11:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change GUI strings in Configuration dialog to reduce user confusion
This is a result of a dialogue with an Amarok user (Leonidas Tsampros)
on #amarok who (logically) thought that if he enables "NFS Device" in
"Devices" section of Amarok plugins, NFS will pop-up as another
collection.
This is not how SMB, NFS, MassStorage "Devices" work currently, they
are meant to enable users to have a part of their collection on
respective devices.
I believe that the old plugin names and descriptions are confusing to
the extent that their translations should be dropped; it should be a
plenty of time till Amarok 2.6 so translators should have opportunity
to pickup these. (or, do .desktop translations get erased automatically
when original string changes?)
CHANGES:
* "Devices" in Amarok configuration -> Plugins is with other related strings
renamed to "Local Collection Backends" to reduce user confusion.
BUG: 293277
FIXED-IN: 2.6</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=293277">293277</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(ed4e955deeebf6a506e87ca8973645b9eeadc67b)</span></li>
<li>src/configdialog/ConfigDialog.cpp <span style="color: grey">(1e8e30a7f02709fb8d02b705faf01de58f52ec94)</span></li>
<li>src/configdialog/dialogs/PluginsConfig.cpp <span style="color: grey">(0e0ff1852ab192be2911cce3ed73dd42f38ab6f3)</span></li>
<li>src/core-impl/collections/db/sql/device/massstorage/amarok_device_massstorage.desktop <span style="color: grey">(34dda8cda57e4ea8eb8980e5b6e3e44019718004)</span></li>
<li>src/core-impl/collections/db/sql/device/nfs/amarok_device_nfs.desktop <span style="color: grey">(66a0b563c1e0daea8c77dd3fb6740c29897182de)</span></li>
<li>src/core-impl/collections/db/sql/device/smb/amarok_device_smb.desktop <span style="color: grey">(82d5715971e6001d4b1a624f256b48ea121a8155)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103871/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>