<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102110/">http://git.reviewboard.kde.org/r/102110/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 21f0003cf22d965f45ef7f2df9e653ddfa5b116f by Ralf Engels to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 28th, 2011, 1:38 p.m., Modestas Vainius wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Modestas Vainius.</div>
<p style="color: grey;"><i>Updated July 28, 2011, 1:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There were some issues mostly when playing streams. Lyrics would stuck with empty text and wouldn't autorefresh until the track was changed or manually refreshed. That's because cachedLyrics() is always empty for streams. Therefore it makes sense to additionally check if either artist or track title have changed as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: grey">(2abeb6d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102110/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>