<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103736/">http://git.reviewboard.kde.org/r/103736/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 20th, 2012, 1:51 p.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the prettyName automatically falls back to the device name it gets from solid it's already configured automatically. As such it's a completely non invasive option in that dialog. It might be a good idea to prevent accidental changes by disabling the editability of the textEntry field, but that is nitpicking and can be done later in a few minutes.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have also changed the implementation of prettyName to return the configured collection name if it exists. Thus, if the user didn't change the collection name in the dialog the name from solid is used. Otherwise, when the user has changed the name in the dialog this changed name is used. So it's not a good idea to disable the editability of the textEntry field as it is essential for this feature!</pre>
<br />
<p>- Volker</p>
<br />
<p>On January 20th, 2012, 11:41 a.m., Volker Christian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Bart Cerneels.</div>
<div>By Volker Christian.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2012, 11:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I sometimes missed the possibility to give an UMS-Collection a descriptive name. This patch adds this feature to the USM-Collection.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/umscollection/UmsCollection.h <span style="color: grey">(7c86fab)</span></li>
<li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: grey">(aaa9a6d)</span></li>
<li>src/core-impl/collections/umscollection/UmsConfiguration.ui <span style="color: grey">(d9a6365)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103736/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103736/s/417/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/19/usm-config-dialog_400x100.png" style="border: 1px black solid;" alt="UMS-Config Dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/103736/s/418/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/19/usm-collection_400x100.png" style="border: 1px black solid;" alt="UMS-Collection" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>