<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103546/">http://git.reviewboard.kde.org/r/103546/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 15th, 2012, 10:56 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, not working for me.
that works:
geändert:>04.01.2012
geändert:<04.01.2010
It does show only a subset of the whole collection.
that doesn't work:
geändert:04.01.2012
It always seem to show the whole collection.
Also I think the localization problem has not been covered.
Does an English date (e.g. 01/04/2012) work? The regular expression seems to be static.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I noticed queries like geändert:04.01.2012 aren't working in the current git version either (probably it never worked at all).
I added an:
qm->endAndOr();
qm->beginAnd();
right before the two:
qm->addNumberFilter(...);
I copied it from the file size filter above and now it works.
Even though I expected something like:
qm->beginAnd();
qm->addNumberFilter(...);
qm->addNumberFilter(...);
qm->endAndOr();
And localization is covered, it depends on your KDE settings for the short date format. This is also the format used by the EditFilterDialog, the two regex are only fallbacks.</pre>
<br />
<p>- Daniel</p>
<br />
<p>On January 16th, 2012, 4:21 p.m., Daniel Faust wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2012, 4:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a collection filter (including gui) to filter using an absolute date (e.g. 26.11.2011). It's an addition to the current time difference mode (e.g. 1 month ago).
Currently filtering the collection by date is a bit confusing and even though there is a gui (in the EditFilterDialog) to select a certain date it gets instantly converted to a time difference. This patch make a clear difference between these two modes (absolute and relative time specification).
The date can be formatted in tree ways, default is the local short format (KLocale::ShortFormat) following regex are also possible:
(\d{1,2})[-.](\d{1,2})
(\d{1,2})[-.](\d{1,2})[-.](\d{4})
The way time differences are handled gets unified though that leads to some code duplication that should also be dealt with.
A new filter condition 'NewerThan' (opposide of 'OlderThan') gets added.
I hope that I didn't forget anything important.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested filtering the collection and editing the filters with the EditFilterDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/support/TextualQueryFilter.h <span style="color: grey">(31860a3)</span></li>
<li>src/core-impl/collections/support/TextualQueryFilter.cpp <span style="color: grey">(2374dbd)</span></li>
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(58c2956)</span></li>
<li>src/widgets/MetaQueryWidget.h <span style="color: grey">(3974fb7)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(57b622f)</span></li>
<li>src/widgets/TokenPool.cpp <span style="color: grey">(2889442)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103546/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>