<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103704/">http://git.reviewboard.kde.org/r/103704/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove setUidUrl function from EditCapability.
The only reference to that was in the Edit dialog, but the code was unreachable.
Also remove setUidUrl from different classes where it was not used.
Conceptually it should not be possible for the unique id of a track to change as we are using it as identifier.
Different uid means different track.
50 code lines less.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All test cases executed.
Compiled and running.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.h <span style="color: grey">(9c6d553)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp <span style="color: grey">(baeed46)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceEditCapability.h <span style="color: grey">(7acfb2b)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceEditCapability.cpp <span style="color: grey">(992c8a5)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(b44c8eb)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(f4d9af4)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(05411a3)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(9e02547)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(9832c6f)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(1893f4b)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(3c33624)</span></li>
<li>src/core/capabilities/EditCapability.h <span style="color: grey">(8064e6a)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(a2ee45d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103704/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>