<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103603/">http://git.reviewboard.kde.org/r/103603/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2012, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look above the album name in the screenshot of CollectionBrowser. You will see that now there is the track count for every album. Also, I had done similar changes in the PodcastBrowser. Those are the perceptible changes at the user interface.
In the programming level, I had modified PlayslistBrowserCategory, CollectionWidget and PodcastCategory, in order to be easier to make delegates for their views. Also, it's easy to implement this system for more QTreeViews used in Amarok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my attempt to make QTreeView subclasses items, used in Amarok, more pretty by displaying some extra information. Notice that these extra information are usually the quantity of tracks in a album, the quantity of episodes in a podcast and the quantity of episodes marked as new in a podcast.
So, please help me to improve this feature even more by answering some questions:
1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser too?
2) Is there any extra information that you think it's relevant to be showed somewhere (In QTreeViews)?
Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch should build. Everything is working as expected and there aren't any known issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(7c2335d)</span></li>
<li>src/browsers/AbstractTreeViewDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/AbstractTreeViewDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/CollectionTreeItem.h <span style="color: grey">(3438adc)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(e7f8e62)</span></li>
<li>src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp <span style="color: grey">(35a8222)</span></li>
<li>src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/collectionbrowser/CollectionTreeItemDelegate.h <span style="color: grey">(8a189e6)</span></li>
<li>src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp <span style="color: grey">(755be00)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: grey">(ac1c26d)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserCategory.h <span style="color: grey">(9198d43)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp <span style="color: grey">(0c2f9c1)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserView.cpp <span style="color: grey">(9c4236d)</span></li>
<li>src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h <span style="color: grey">(3a094b0)</span></li>
<li>src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp <span style="color: grey">(bc76551)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsByProviderProxy.h <span style="color: grey">(941268c)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp <span style="color: grey">(12f2676)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h <span style="color: grey">(9a01dbe)</span></li>
<li>src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp <span style="color: grey">(4268a82)</span></li>
<li>src/browsers/playlistbrowser/PodcastCategory.cpp <span style="color: grey">(1c353dc)</span></li>
<li>src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: grey">(e88f4a1)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(18334f6)</span></li>
<li>src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/playlistbrowser/UserPlaylistCategory.cpp <span style="color: grey">(b48a55f)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(42ad039)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(1c3bdf4)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(679f7ac)</span></li>
<li>src/core/podcasts/PodcastMeta.cpp <span style="color: grey">(b9851f7)</span></li>
<li>src/widgets/TrackSelectWidget.cpp <span style="color: grey">(5bd5059)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103603/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103603/s/389/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/02/podcastBrowser_400x100.jpeg" style="border: 1px black solid;" alt="PodcastBrowser" /></a>
<a href="http://git.reviewboard.kde.org/r/103603/s/390/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/02/collectionBrowser_400x100.jpeg" style="border: 1px black solid;" alt="CollectionBrowser" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>