<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102964/">http://git.reviewboard.kde.org/r/102964/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d2989df638119911e7e62526e0bee0914f731e4f by Matěj Laitl to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 26th, 2011, 2:11 p.m., Matěj Laitl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matěj Laitl.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2011, 2:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">iPod handler: raise libgpod dep to 0.7.93 and simplify iTunes db writing
Even Debian stable has libgpod-0.7.93 packaged in main repo, so this
shouldn't hurt and this version is much more convenient to work with.
The change is logged in ChangeLog and README is also adjusted.
--
iPod handler: cleanup slots that are called when worker threads are done
There was a logic error - slot...Succeeded slots were called even when
the thread did not succeed. (because they were connected to the "done"
signals) This is fixed now.
It seems that some actions (writing to debug() etc.) performed upon job
failures were removed, but they were in fact already duplicated in
slot...Succeeded methods.
Stale & orphaned needs much more work, this is just a start.
--
iPod handler: remove unused attributes
these attributes, enums and fwd-declarations aren't used, remove them.
--</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything still works with iPod nano 2G and iPod nano 4G. It would be great if someone with iPod shuffle could test, as a part of code only relevant for shuffles is touched.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1ffb60e072346b7af368adcfd2ac5e9daa6b4bf9)</span></li>
<li>ChangeLog <span style="color: grey">(a99a4de75b1941ecdc7cb3b41cce9ad3c996df27)</span></li>
<li>README <span style="color: grey">(619bc56f238cbd132f0c5c0647058c17f16d0caa)</span></li>
<li>src/core-impl/collections/ipodcollection/CMakeLists.txt <span style="color: grey">(1bf1aa49601d6eedfde741eaf7e232a81a9bd4bb)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.h <span style="color: grey">(24ba45ad507b127d6bbb92ca367afb31f5e86460)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp <span style="color: grey">(041eecf60d79fe0203dfb824186cbe96a9a696a5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102964/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>