<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102956/">http://git.reviewboard.kde.org/r/102956/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 24th, 2011, 4:56 p.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good, thanks for your work, Silver.
I've found an interesting corner case - while the keyboard is always focused to collection search upon CTRL+F, the collection widget itself does not show itself if it was previously hidden - see these screenshots to see when it happens: http://www.laitl.cz/soubory/amarok-ctrl-f-1.jpeg http://www.laitl.cz/soubory/amarok-ctrl-f-2.jpeg
You may perhaps have luck looking at the "Amarok bookmarks" code to see how to raise Collection browser widget - especially the part dealing with amarok://navigate/... urls.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like a very nice feature.
And as somebody having tabbed the collection view myself, I would like to see the calling of a bookmark, too.
Something like this should do the trick.
#include "amarokurls/AmarokUrl.h"
AmarokUrl bookmark( "amarok://navigate/collections" );
bookmark.run();</pre>
<br />
<p>- Daniel</p>
<br />
<p>On October 24th, 2011, 4:31 p.m., Silver Juurik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Silver Juurik.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2011, 4:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch adds a keyboard shortcut for moving focus to collection search input box. The default shortcut is ctrl+F.
The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to playlist search box) and ctrl+F partially solve the problem described in the bug.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(076628f)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(2d2ebac)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.h <span style="color: grey">(a206914)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: grey">(ace058a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102956/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>