<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102596/">http://git.reviewboard.kde.org/r/102596/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Sven Krohlas.</div>


<p style="color: grey;"><i>Updated Oct. 19, 2011, 9:48 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* should be thread safe now
* view: visual problems fixed
* view: correctly updates now ^^</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  (updated)</h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What works:
* compiling, linking, installing ^^
* searching for items in the amazon store (set your location in the plugin settings first, Germany works atm, US and JP don't)
* displaying the search results in the browser
* adding stuff to the shopping cart and checking it out (no gui to view the cart or remove items yet)

TODO: just grep for "TODO" in the patch. basically: language selection needs to be enforced, shopping cart functionality is not yet complete, adding preview streams to the playlist

Any help is very appreciated. ^^ Also, I need artwork and I'm not an artist at all.

Important: searching for items might take up to 30 seconds atm. This is going to improve to about 2 seconds once the cache of Amazon Item IDs on the server side has been filled. Those IDs are being cached forever. ;-)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">only in the German Amazon store. works.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(119f90d)</span></li>

 <li>src/core-impl/collections/support/MemoryQueryMakerInternal.h <span style="color: grey">(d3825ca)</span></li>

 <li>src/core/collections/Collection.h <span style="color: grey">(02b0894)</span></li>

 <li>src/core/collections/QueryMaker.h <span style="color: grey">(dfca79f)</span></li>

 <li>src/services/CMakeLists.txt <span style="color: grey">(ad14fda)</span></li>

 <li>src/services/ServiceCollection.h <span style="color: grey">(7a57aa6)</span></li>

 <li>src/services/ServiceMetaBase.cpp <span style="color: grey">(21587d3)</span></li>

 <li>src/services/amazon/Amazon.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonActions.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonActions.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonCart.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonCart.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonCartItem.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonCartItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonCollection.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonConfig.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonConfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonItemTreeModel.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonItemTreeModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonItemTreeView.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonItemTreeView.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonMeta.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonParser.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonParser.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonSettingsModule.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonSettingsModule.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonStore.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/AmazonStore.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/services/amazon/amarok_service_amazonstore_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102596/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/102596/s/311/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/17/amarok_amazon_view_400x100.png" style="border: 1px black solid;" alt="Search result for "cure" in the German store" /></a>

</div>


  </td>
 </tr>
</table>




  </div>
 </body>
</html>