<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102600/">http://git.reviewboard.kde.org/r/102600/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested it on a clean config. After enabling the plugin I got a KIO login dialog, you should look into the libgpo-qt calls an avoid calling those that need login before the credentials have been entered in amarok.
I had to restart to get the gpodder provider to show up.
I can't tell if the interaction with gpodder.net is fully working yet, since the service is experiencing it's usual overload.</pre>
<br />
<p>- Bart</p>
<br />
<p>On September 24th, 2011, 2:25 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2011, 2:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached diff is the work done during this summer to integrate gpodder.net web service with Amarok.
Added features:
Podcast subscription synchronisation.
Podcast status synchronisation.
Browse through podcasts suggested by gpodder.net.
Browse through gpodder.net top recommended podcasts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the result of git diff for the range of several commits prior to HEAD, rebased on current master, and should build. Everything is working as expected and there aren't any known issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(962070d)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.h <span style="color: grey">(76ccb10)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: grey">(ff18d83)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: grey">(ce1a86f)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(4aad518)</span></li>
<li>src/browsers/playlistbrowser/QtGroupingProxy.cpp <span style="color: grey">(e0b4e7a)</span></li>
<li>src/core-impl/playlists/types/file/PlaylistFileSupport.cpp <span style="color: grey">(2dcc0cd)</span></li>
<li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: grey">(c64cb97)</span></li>
<li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(0a3c99a)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(0110911)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(e88bc9e)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(83e9b99)</span></li>
<li>src/core/playlists/Playlist.h <span style="color: grey">(f88b070)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(21364b4)</span></li>
<li>src/core/podcasts/PodcastMeta.cpp <span style="color: grey">(fb82fa8)</span></li>
<li>src/main.cpp <span style="color: grey">(7306e84)</span></li>
<li>src/playlistmanager/PlaylistManager.h <span style="color: grey">(54d63b1)</span></li>
<li>src/playlistmanager/PlaylistManager.cpp <span style="color: grey">(333ff17)</span></li>
<li>src/playlistmanager/SyncRelationStorage.h <span style="color: grey">(2a2681d)</span></li>
<li>src/playlistmanager/SyncRelationStorage.cpp <span style="color: grey">(b151243)</span></li>
<li>src/playlistmanager/SyncedPlaylist.h <span style="color: grey">(54914c7)</span></li>
<li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: grey">(c8383b5)</span></li>
<li>src/playlistmanager/SyncedPodcast.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/SyncedPodcast.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.h <span style="color: grey">(4674f66)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: grey">(a857593)</span></li>
<li>src/playlistmanager/file/PlaylistFileProvider.cpp <span style="color: grey">(728030d)</span></li>
<li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: grey">(b2a9ca5)</span></li>
<li>src/services/gpodder/CMakeLists.txt <span style="color: grey">(97f14b3)</span></li>
<li>src/services/gpodder/GpodderConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: grey">(fac508a)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(e0cb02f)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceModel.h <span style="color: grey">(1fbc90d)</span></li>
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: grey">(d899456)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTreeItem.h <span style="color: grey">(5698d5b)</span></li>
<li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: grey">(bfa216e)</span></li>
<li>src/services/gpodder/amarok_service_gpodder_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102600/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>