<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102600/">http://git.reviewboard.kde.org/r/102600/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just had a quick look at it, 2 small things first:
-) you do some debug output in PlaylistBrowser.. (one of the first files), this is maybe a relic from development, think about if it is needed in master and if yes then try to make it a better debug output
-) every file where you did a substantial change, you should write your name in the copyright header </pre>
<br />
<p>- Stefan</p>
<br />
<p>On September 13th, 2011, 10:44 p.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2011, 10:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached diff is the work done during this summer to integrate gpodder.net web service with Amarok.
Added features:
Podcast subscription synchronisation.
Podcast status synchronisation.
Browse through podcasts suggested by gpodder.net.
Browse through gpodder.net top recommended podcasts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is the result of git diff for the range of several commits prior to HEAD, rebased on current master, and should build. Everything is working as expected and there aren't any known issues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(962070d3b50089a29fee7d9a3154639602a3332a)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.h <span style="color: grey">(76ccb10313e0c1451c2531c82957790cd963da8e)</span></li>
<li>src/browsers/playlistbrowser/PlaylistBrowserModel.cpp <span style="color: grey">(ff18d83c4fde71f27afa357d7bfe9883f31d0032)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: grey">(ce1a86ffb92f8833896c28dfe9988532a2b78437)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(4aad518713356e97fd69abe0ca0962df8bb23eef)</span></li>
<li>src/browsers/playlistbrowser/QtGroupingProxy.cpp <span style="color: grey">(e0b4e7a1e7616e8708b0fe5eddf9aa9039f2b413)</span></li>
<li>src/core-impl/playlists/types/file/PlaylistFileSupport.cpp <span style="color: grey">(2dcc0cdd9c706e3840e5a38b9cfec0c1c1d0c3ac)</span></li>
<li>src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp <span style="color: grey">(c64cb976553348a824d0107520492c8ecf779287)</span></li>
<li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(0a3c99aa1034a73109e75ce447b8b9177f1670e8)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(011091158b7d5fbb215e87b6c5c76dd96a5faa98)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(e88bc9e345ba39bc4f92f5ff4adbc0b4795f9893)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(83e9b99291b880ba3ec2466fb40c28812e6b3a39)</span></li>
<li>src/core/playlists/Playlist.h <span style="color: grey">(f88b07043056e7990f5ade76bc58e8dccc837caf)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(21364b410ff0fdc9524a2d521538e361b40de209)</span></li>
<li>src/core/podcasts/PodcastMeta.cpp <span style="color: grey">(fb82fa87778028aeb68ab2e64ec5964482b21009)</span></li>
<li>src/main.cpp <span style="color: grey">(7306e84a7c31f402b52edca901f7430999acbc27)</span></li>
<li>src/playlistmanager/PlaylistManager.h <span style="color: grey">(54d63b1a4b0330d91c8eb088e1ff4105a62bf9e1)</span></li>
<li>src/playlistmanager/PlaylistManager.cpp <span style="color: grey">(333ff17daad3c99bd81f70d206c0299b54115fce)</span></li>
<li>src/playlistmanager/SyncRelationStorage.h <span style="color: grey">(2a2681da85b608558834d66c73c115fda0aa4eed)</span></li>
<li>src/playlistmanager/SyncRelationStorage.cpp <span style="color: grey">(b151243fc10f787113cb0792083d4d723c3a49ba)</span></li>
<li>src/playlistmanager/SyncedPlaylist.h <span style="color: grey">(54914c751dc5253bd51ca2ce1af6b64061994068)</span></li>
<li>src/playlistmanager/SyncedPlaylist.cpp <span style="color: grey">(c8383b5b08e11ffff25310ddeebe714869a0c3d3)</span></li>
<li>src/playlistmanager/SyncedPodcast.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/SyncedPodcast.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.h <span style="color: grey">(4674f660532e782299f433888743624c551c98b6)</span></li>
<li>src/playlistmanager/file/KConfigSyncRelStore.cpp <span style="color: grey">(a8575935302fc396c75ab452ec9d7787f8a20422)</span></li>
<li>src/playlistmanager/file/PlaylistFileProvider.cpp <span style="color: grey">(728030d4c73656cb3354db2b03df2cbba1129b9c)</span></li>
<li>src/playlistmanager/sql/SqlPlaylist.cpp <span style="color: grey">(b2a9ca52589882a4877b687abd6dd04967237db0)</span></li>
<li>src/services/gpodder/CMakeLists.txt <span style="color: grey">(97f14b33c1728165e15d5f524a3e102896775cdf)</span></li>
<li>src/services/gpodder/GpodderConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: grey">(fac508a8b0d5af293ae3529025690b8b740c7550)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(e0cb02f33c6be9ae2aa2cf5939e40e9689fac027)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceModel.h <span style="color: grey">(1fbc90d637078754aa91a932e46a46b869b97c33)</span></li>
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: grey">(d899456b530752199012e5441a36b0ada643b793)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTreeItem.h <span style="color: grey">(5698d5bf64456947e8e86efb1e3b7a089515e423)</span></li>
<li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: grey">(bfa216e58439af6c6961396143cdb5d10e8d7684)</span></li>
<li>src/services/gpodder/amarok_service_gpodder_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102600/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>