<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102444/">http://git.reviewboard.kde.org/r/102444/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bde537bb2f150ee49e980e97e4bcffd72e4bdb0c by Alex Merry to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 26th, 2011, 2:48 p.m., Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 2:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One of the things that bugs me about Amarok is that if it crashes (as it tends to do on logout, for me), the playlist is lost, and next time you start it up it gives you the playlist from the last time it exited properly.
This fixes that by auto-saving the playlist state. It schedules a save for 5 seconds in the future when a change is made to the playlist - any changes made withing those 5 seconds will not trigger a further save, but will be included in the scheduled save. This prevents the disk being hammered when making a flurry of changes.
Possibly this timeout should be longer - 20 seconds?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed the playlist, waited 5 seconds, killed amarok (killall -9 amarok). Starting up Amarok again displayed the modified playlist.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(ca2d6561ac607ad3dd4886a33a357f3add0b2eaf)</span></li>
<li>src/playlist/PlaylistModel.h <span style="color: grey">(21e5f2ca8a4fdb2ccf77c8ea2b3cb47bf2a1c5e8)</span></li>
<li>src/playlist/PlaylistModel.cpp <span style="color: grey">(842095a11f649fd9a91f5bb53869ac607a552749)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102444/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>