<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102181/">http://git.reviewboard.kde.org/r/102181/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Sandeep,
The patch looks really good, coding style, logic constructs, inlie docs, all top notch.
Sorry for not reviewing sooner, the Desktop Summit and post conference catchup with work ate my time.
I'll try it out later today and perhaps commit if it's functional, or would you like to push it instead?
Bart</pre>
<br />
<p>- Bart</p>
<br />
<p>On August 2nd, 2011, 2:38 p.m., Sandeep Raghuraman wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sandeep Raghuraman.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2011, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improved isPlayable functions for some classes derived from Meta::Track. TrackNavigator will not queue unplayable tracks. StandardTrackNavigator::chooseNextTrack now skips unplayable tracks and returns the next playable track in the list. Unplayable tracks are grayed in the playlist to show that they are unavailable.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with local files only. Cannot test with audio CD's since mine doesn't work. Going to test Upnp and Ampache tracks and Daap tracks if possible.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=263640">263640</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/audiocd/AudioCdMeta.cpp <span style="color: grey">(c4a791e)</span></li>
<li>src/core-impl/collections/daap/CMakeLists.txt <span style="color: grey">(c60b371)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.cpp <span style="color: grey">(b8431dd)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(5daed6d)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: grey">(4d44acf)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(d8d516e)</span></li>
<li>src/core-impl/meta/stream/Stream.cpp <span style="color: grey">(5a6659c)</span></li>
<li>src/playlist/navigators/StandardTrackNavigator.cpp <span style="color: grey">(9675876)</span></li>
<li>src/playlist/navigators/TrackNavigator.cpp <span style="color: grey">(6fbfc55)</span></li>
<li>src/playlist/view/PlaylistViewCommon.cpp <span style="color: grey">(db300a3)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: grey">(08b0724)</span></li>
<li>src/services/ampache/AmpacheMeta.h <span style="color: grey">(fa104ec)</span></li>
<li>src/services/ampache/AmpacheMeta.cpp <span style="color: grey">(2b85a7b)</span></li>
<li>src/services/ampache/CMakeLists.txt <span style="color: grey">(e3d09af)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: grey">(055dfef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102181/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>