<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102243/">http://git.reviewboard.kde.org/r/102243/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Phonon.</div>
<div>By Alessandro Siniscalchi.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2011, 2:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Better Style</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added two modules to amarok:
audiodatacenter: it will let all modules that needs raw data to register there. It manages the audioDataOutput path and all the user has not to know.
audiodataclient: the interface to implement to register to audiodatacenter
visualM: It starts the projectM-qt project ---> Visualization
I used the phonon from git repository cause audioDataOutput is fixed in gstreamer backend
Yeah !!!!!
TODO: fix a bug in PAth::disconnect. When I disconnect the audioDataOutput ... the audio stops and I have to press play button another time .. I think it deactives the amarok audio path too... I will check
Screenshot: http://imageshack.us/photo/my-images/190/unledyzl.png/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(b086375c963c143a5baf23bd11165302e97ba6e4)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(00ecacfd242c5c39fce84807620c8a04852d1489)</span></li>
<li>src/EngineController.h <span style="color: grey">(ddd8f1b6eef363cebdc596f968f98f5392a5e13c)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(18fbe50732b256e5e051ad08a1b9523d5207dc74)</span></li>
<li>src/MainWindow.h <span style="color: grey">(076628f4b1c12d094b761867c600de2746d076bf)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(2d2ebacce172fffaaf313294b690424e827b800b)</span></li>
<li>src/audiodatacenter/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/audiodatacenter/audiodatacenter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/audiodatacenter/audiodatacenter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/audiodatacenter/audiodataclient.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/audiodatacenter/audiodataclient.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/CMakeLists.txt <span style="color: grey">(7c210b08c518c5a240d7ce825306de3cfcb2cb21)</span></li>
<li>src/context/applets/albums/CMakeLists.txt <span style="color: grey">(4989f3167807a75168774c8c4bef3faa485ce41b)</span></li>
<li>src/context/applets/currenttrack/CMakeLists.txt <span style="color: grey">(ccc1aabf6a0ecca96e89388c990801417862d00c)</span></li>
<li>src/context/applets/info/CMakeLists.txt <span style="color: grey">(8b4aa20b3c3a71fd190f7e9d2067a9d71c9c742b)</span></li>
<li>src/context/applets/labels/CMakeLists.txt <span style="color: grey">(6309d178706396391c8de08dc63ac2433fcbccba)</span></li>
<li>src/context/applets/lyrics/CMakeLists.txt <span style="color: grey">(7ed42066a0d048b6cc9393f33a0aec8d10b1cf09)</span></li>
<li>src/context/applets/photos/CMakeLists.txt <span style="color: grey">(ac5eb212170c1bf8c7c2cf04557403078ad1fcab)</span></li>
<li>src/context/applets/videoclip/CMakeLists.txt <span style="color: grey">(cfafdf22d69f45bceb7b851d7eba3d24482d5b88)</span></li>
<li>src/context/applets/wikipedia/CMakeLists.txt <span style="color: grey">(adb1952eff693fc289506ec5b48776d56fd89f5d)</span></li>
<li>src/core-impl/collections/CMakeLists.txt <span style="color: grey">(c78b9202ece71b51189c4e47d85acfa4a74ef8d6)</span></li>
<li>src/core-impl/collections/audiocd/CMakeLists.txt <span style="color: grey">(26f95387f1994e9473c283a1399badb34cb8f566)</span></li>
<li>src/core-impl/collections/db/sql/CMakeLists.txt <span style="color: grey">(0ed51cd13285d10a61f5dc48284f88884fbb0238)</span></li>
<li>src/core-impl/collections/mtpcollection/CMakeLists.txt <span style="color: grey">(581e952f7a35dd3db616fb3e4a4d31b671645128)</span></li>
<li>src/services/opmldirectory/CMakeLists.txt <span style="color: grey">(1ae294c93d54861f5c013a64d8cad62baff52c4c)</span></li>
<li>src/visualm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/visualm/visualm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/visualm/visualm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102243/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>