<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102079/">http://git.reviewboard.kde.org/r/102079/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FYI: http://quickgit.kde.org/?p=amarok.git&a=commitdiff&h=202c49ebf8b5521b0394b4b7c5e816bf4057c8de</pre>
<br />
<p>- Bart</p>
<br />
<p>On July 24th, 2011, 9:36 p.m., Sam Lade wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sam Lade.</div>
<p style="color: grey;"><i>Updated July 24, 2011, 9:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As of commit 202c49ebf8b5521b0394b4b7c5e816bf4057c8de, if the Last.FM plugin is enabled, but no username and password are set, a request for the username and password is popped up on Amarok start.
This is because this commit calls polish() on each service as it is created. If the service hasn't set m_inited = true when this happens (which is the case when no last.fm username and password are set), a dialogue pops up asking for them.
This simply removes that call. It was never run in older versions of Amarok, since apparently polish() was never called.
There may be better ways of doing it, but if so I can't work them out. Everything seems to work properly this way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Amarok started with and without last.fm credentials set. Everything seems to behave as expected. No badgering popups are shown.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/lastfm/LastFmService.cpp <span style="color: grey">(ce0b6ec09f3403c44cb26eece994637d2db5db15)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102079/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>