<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101745/">http://git.reviewboard.kde.org/r/101745/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Bart Cerneels.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes all calls to The::statusbar() and the StatusBar class itself.
Messages and progress now all use Amarok::Compoments::logger() and methods from core/interface/Logger.h.
Made Amarok::Logger a pure virtual class, not deriving from QObject so multiple inheritance is possible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">SqlPodcastProvider, AmarokStatusbarScript.
Could not test all users of The::statusBar() like MP3Tunes, UPnP, MediaDevice, etc.
In depth testing is required for risk of regressions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(44c9df6)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(2d22b80)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(dc1b1a6)</span></li>
<li>src/MountPointManager.cpp <span style="color: grey">(cb9b076)</span></li>
<li>src/browsers/BrowserDock.h <span style="color: grey">(d172fcc)</span></li>
<li>src/browsers/BrowserDock.cpp <span style="color: grey">(e1aafb0)</span></li>
<li>src/browsers/BrowserMessageArea.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/BrowserMessageArea.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/browsers/filebrowser/FileView.cpp <span style="color: grey">(f5fe169)</span></li>
<li>src/browsers/playlistbrowser/UserPlaylistCategory.cpp <span style="color: grey">(bc11a71)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.cpp <span style="color: grey">(d3ea3a9)</span></li>
<li>src/core-impl/collections/daap/daapreader/Reader.cpp <span style="color: grey">(e4c6b64)</span></li>
<li>src/core-impl/collections/db/ScanManager.cpp <span style="color: grey">(b5da510)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollectionLocation.cpp <span style="color: grey">(fc4464d)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp <span style="color: grey">(216b200)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp <span style="color: grey">(0a902a2)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h <span style="color: grey">(d6ad43e)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp <span style="color: grey">(ec0dcbc)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp <span style="color: grey">(be0c918)</span></li>
<li>src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp <span style="color: grey">(01e8f22)</span></li>
<li>src/core-impl/collections/support/FileCollectionLocation.cpp <span style="color: grey">(d743c9d)</span></li>
<li>src/core-impl/collections/support/TrashCollectionLocation.cpp <span style="color: grey">(26859c5)</span></li>
<li>src/core-impl/collections/umscollection/handler/UmsHandler.h <span style="color: grey">(44cacf6)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.h <span style="color: grey">(03b26f1)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp <span style="color: grey">(e6b4338)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpSearchCollection.cpp <span style="color: grey">(8525039)</span></li>
<li>src/core-impl/logger/ProxyLogger.h <span style="color: grey">(d02ff73)</span></li>
<li>src/core-impl/logger/ProxyLogger.cpp <span style="color: grey">(9f8923a)</span></li>
<li>src/core-impl/playlists/types/file/PlaylistFileSupport.cpp <span style="color: grey">(5e35e8b)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(385a6ac)</span></li>
<li>src/core/interfaces/Logger.h <span style="color: grey">(e89aaf4)</span></li>
<li>src/dynamic/BiasedPlaylist.h <span style="color: grey">(52f7548)</span></li>
<li>src/dynamic/BiasedPlaylist.cpp <span style="color: grey">(e40a1ab)</span></li>
<li>src/playlist/layouts/LayoutManager.cpp <span style="color: grey">(80f74d9)</span></li>
<li>src/playlistgenerator/ConstraintSolver.cpp <span style="color: grey">(3d2d960)</span></li>
<li>src/playlistgenerator/Preset.h <span style="color: grey">(ecf5147)</span></li>
<li>src/playlistgenerator/Preset.cpp <span style="color: grey">(ffec0d3)</span></li>
<li>src/playlistgenerator/PresetModel.cpp <span style="color: grey">(269c1af)</span></li>
<li>src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h <span style="color: grey">(b407601)</span></li>
<li>src/services/magnatune/MagnatuneAlbumDownloader.cpp <span style="color: grey">(564809b)</span></li>
<li>src/services/magnatune/MagnatuneDownloadHandler.cpp <span style="color: grey">(a01e7c7)</span></li>
<li>src/services/mp3tunes/Mp3tunesService.cpp <span style="color: grey">(6ef5e27)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp <span style="color: grey">(acfe9db)</span></li>
<li>src/services/mp3tunes/Mp3tunesWorkers.h <span style="color: grey">(be43911)</span></li>
<li>src/services/mp3tunes/Mp3tunesWorkers.cpp <span style="color: grey">(ec037b5)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryInfoParser.cpp <span style="color: grey">(08a9c81)</span></li>
<li>src/statusbar/CompoundProgressBar.h <span style="color: grey">(d08236e)</span></li>
<li>src/statusbar/CompoundProgressBar.cpp <span style="color: grey">(9d7daf5)</span></li>
<li>src/statusbar/LongMessageWidget.h <span style="color: grey">(b70e937)</span></li>
<li>src/statusbar/LongMessageWidget.cpp <span style="color: grey">(01274db)</span></li>
<li>src/statusbar/ProgressBar.h <span style="color: grey">(182575a)</span></li>
<li>src/statusbar/StatusBar.h <span style="color: grey">(5fd3996)</span></li>
<li>src/statusbar/StatusBar.cpp <span style="color: grey">(e977223)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101745/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>