<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100841/">http://git.reviewboard.kde.org/r/100841/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 6th, 2011, 12:04 p.m., <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, so far so good. We're getting there ;)
Two other remarks that prevent your patch from being applied.
* Please fix the look of your applet when you have albums with no cover set, there's still some gray bg showing up, it seems. Looks a bit
* I'd recommend disabling the horizontal scrollbar completely and fill up the space that's actually there.
Other than that, looks fine.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">about the "no cover" problem, could it be that when applying the patch you're not getting the "defaultcover.png" image which should show up in that case ?
as for the horizontal scrollbar, I'll try my best ;)</pre>
<br />
<p>- Manu</p>
<br />
<p>On June 5th, 2011, 3:55 p.m., Manu Wagner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Manu Wagner.</div>
<p style="color: grey;"><i>Updated June 5, 2011, 3:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a new context applet, called CoverGrid.
It displays all albums of the collection by their cover art in a grid view.
Tooltips display album & artist names, mouse double click appends album to playlist</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">basic functionalities seem to work</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/CMakeLists.txt <span style="color: grey">(25b3f0b)</span></li>
<li>src/context/applets/covergrid/AlbumItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/AlbumItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/CoverGridApplet.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/CoverGridApplet.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/amarok-context-applet-covergrid.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/covergridSettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/covergrid/defaultcover.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100841/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100841/s/96/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/11/screenshot_001_1_400x100.jpeg" style="border: 1px black solid;" alt="new applet in action" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>