<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100965/">http://git.reviewboard.kde.org/r/100965/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't we rather change the location of the desktop file than the mpris identifier.
After all Amarok is not really part of kde4.
</pre>
<br />
<p>- Ralf</p>
<br />
<p>On March 29th, 2011, 10:52 a.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated March 29, 2011, 10:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prepending "kde4" to the desktop file name is necessary for Ubuntu Sound Menu (and maybe others) to find Amarok desktop file because it is installed in $prefix/share/applications/kde4, not in $prefix/share/applications.
See http://standards.freedesktop.org/menu-spec/1.0/go01.html#term-desktop-file-id for more info.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dbus/mpris2/Mpris2DBusHandler.cpp <span style="color: grey">(bd69a05)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>