<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101347/">http://git.reviewboard.kde.org/r/101347/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 14th, 2011, 11:37 a.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would like not to use seperate backends for the cache, but for now I guess there is no way around.
I would say ship it, but could you have a look at the code. I found several places where a QPixmapCache is used and using three kinds of caches seems to be a little bit over the top for me.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QPixmapCache does something different - it caches the actual pixmaps (on the X server), rather than just the image data. I renamed my compatibility class to ImageCache to make the distintion more obvious, and put some apidocs comments in to clarify. CoverCache should definitely be using QPixmapCache and not KPixmapCache/KImageCache, for example.</pre>
<br />
<p>- Alex</p>
<br />
<p>On May 12th, 2011, 11:52 p.m., Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 12, 2011, 11:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KPixmapCache is horribly buggy, and that is unlikely to ever change. Its replacement, KImageCache, is much better, but is only available with kdelibs 4.5 and later. So we use KImageCache if we are building against kdelibs 4.5 or later.
To simplify this, I've created a header-only all-inline class PixmapCache which is a practically-zero-cost wrapper around either KPixmapCache or KImageCache.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works with latest kdelibs. Haven't checked build against kdelibs 4.4.x.
This fixes at least one crash that I could reproduce reliably.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8b4134f)</span></li>
<li>ChangeLog <span style="color: grey">(b278ef3)</span></li>
<li>config-amarok.h.cmake <span style="color: grey">(bcf9c8b)</span></li>
<li>src/App.cpp <span style="color: grey">(1f01536)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(5c14e89)</span></li>
<li>src/PixmapCache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/SvgHandler.h <span style="color: grey">(7425cde)</span></li>
<li>src/SvgHandler.cpp <span style="color: grey">(765eda0)</span></li>
<li>src/moodbar/MoodbarManager.h <span style="color: grey">(e3f32b5)</span></li>
<li>src/moodbar/MoodbarManager.cpp <span style="color: grey">(acde9e2)</span></li>
<li>src/widgets/BookmarkPopup.cpp <span style="color: grey">(1f62537)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101347/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>