<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100194/">http://git.reviewboard.kde.org/r/100194/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 27th, 2010, 9:19 a.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100194/diff/1/?file=4920#file4920line74" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">UmsConnectionAssistant::~UmsConnectionAssistant()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">&&</span><span class="hl"> </span><span class="n"><span class="hl">drive</span></span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">drive</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">isHotpluggable</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="o"><span class="hl">||</span></span> <span class="n">drive</span><span class="o">-></span><span class="n">isRemovable</span><span class="p">()<span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">&&</span> <span class="n">drive</span><span class="o">-></span><span class="n">isRemovable</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We still need check drive for existence to prevent crashes. What was wrong with HP devices?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree. The drive check should probably still be there.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On December 8th, 2010, 9:55 p.m., Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2010, 9:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes identifying general USB storage mode media players, plus adds some minor fixes and cleanups. The main change is in UmsConnectionAssistant::identify method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MediaDeviceCache.cpp <span style="color: grey">(babb8ff)</span></li>
<li>src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp <span style="color: grey">(92339ff)</span></li>
<li>src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp <span style="color: grey">(5956a2b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100194/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100194/s/21/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/12/08/amarok-usb_400x100.png" style="border: 1px black solid;" alt="Amarok in USB mode" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>