<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100630/">http://git.reviewboard.kde.org/r/100630/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi all,
I spend a lot of time making the dynamic playlist easier to understand without loosing (much) functionality.
The changes since the last review are:
1. added a SearchBias where you can use a normal search query to filter your songs. Just like in the filter.
2. Use a normal tree view without much fancy widgets in it. This makes the playlist much easier to understand. See screenshot:
http://i.imgur.com/uVbzf.jpg
3. preventing duplicates is no a global switch. No additional bias or setting needed
4. The "not" bias is not longer there. Instead we have a "invert" flag for the only bias where it makes sense. The SearchBias has this functionality already.
5. Drag and drop should work. So you can re-order a bias or a playlist by simply dragging it.
6. There are four default playlists from very simple to moderately complex showing a novice user what you can do.
So, please have a look at the dynamicplaylist branch and give me your feedback.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On February 11th, 2011, 5:19 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2011, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fix (actually not the attached patch but the dynamicplaylist branch) changes most of the dynamic playlist.
Main parts are the UI which was seen as confusing by many users and produced unexpected results.
The global bias is now a "part" bias which allows you to set a part of the collection matching a criteria.
The custom bias is now part of the bias system. I converted all existing custom biases to the new interface just to make sure that it's usable.
The fuzzy bias was completely removed. If someone really wants to have a bias which results in a normal distribution of one numeric value then please feel free to add it again. For now you can define this kind of bias by defining something like this "(rating > 1) AND (rating < 4)"
The branch needs to be merged back to mainline and might have conflicts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used it for a couple of times and wrote new auto tests.
Tested against bug reports.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=175163">175163</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=175172">175172</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=177627">177627</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=188360">188360</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=188360">188360</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=228738">228738</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=230773">230773</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=232673">232673</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=233859">233859</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=260001">260001</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=260003">260003</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=265191">265191</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=and">and</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=more">more</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=probably">probably</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=some">some</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(809d5e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100630/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>