<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100889/">http://git.reviewboard.kde.org/r/100889/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 19th, 2011, 10:55 p.m., <b>Rick W. Chen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, I've got a similar patch in the queue as well. It checks whether the parent device's vencor is "Apple". What I need to find out is is this heirarchy the same with other gen iproducts or not.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding a check for 'Apple' might be a good thing to do for this patch as well...
As for checking for the hierarchy things - current patch still tries first to see if the current device has product containing iPod and only *then* checks the parent ! I'd say it should be pretty safe.
Also, as a FYI, as I posted on the linked forum thread, until the patch goes live to users, users could use a udev rule, like: /lib/udev/rules.d/91_myipod.rules:
ENV{ID_FS_UUID}=="3141-5926", ENV{ID_FS_LABEL} ="iPod_cristi", ENV{ID_FS_LABEL_ENC} = "iPod_cristi"
where FS_UUID needs to be determined first, and label can be changed, but need to keep it starting with 'iPod'.
</pre>
<br />
<p>- Cristi</p>
<br />
<p>On March 19th, 2011, 5:15 p.m., Cristi Posoiu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Cristi Posoiu.</div>
<p style="color: grey;"><i>Updated March 19, 2011, 5:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using KDE 4.6.1 (Mandriva Cooker, x86_64) and Amarok 2.4.0.
It seems I have the same problem people are complaining in http://forum.kde.org/viewtopic.php?f=115&t=93018
Amarok sees my ipod only as a simple usb storage disk, even though in it there are those particular directories and files (iPod_Control/, SysExtendedInfo, etc).
When plugging, I get /dev/sdb1 mounted.
Running solid-hardware list details, KDE Solid is returning for it a Vendor name ("Apple") and as product, since it is a partition, the partition label.
As such, code from .../support/IpodConnectionAssistant.cpp can't match it.
In Solid data, /dev/sdb shows though the appropriate product string ("iPod").
So, what this code does, is that it tries to do that product string matching also on parent's device.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">started amarok and I get to see my ipod + everything on it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp <span style="color: grey">(92339ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100889/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>