<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100686/">http://git.reviewboard.kde.org/r/100686/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2011, 9:54 p.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100686/diff/2/?file=10665#file10665line1461" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/podcasts/sql/SqlPodcastProvider.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SqlPodcastProvider::downloadResult( KJob *job )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1461</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">layoutmap</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span> <span class="s">"album"</span><span class="p">,</span> <span class="n">sqlEpisode</span><span class="o">-></span><span class="n">album</span><span class="p">()</span><span class="o">-></span><span class="n">prettyName</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One more crash on track without album.
Checks are needed for all fields those can be absent.</pre>
</blockquote>
<p>On March 14th, 2011, 3:34 a.m., <b>Sandeep Raghuraman</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As above, Album::prettyName() returns "Unknown Album", so this shouldn't be a problem. However, if you think it is I could change the code to check and replace by a space/empty string instead.</pre>
</blockquote>
<p>On March 15th, 2011, 4:45 a.m., <b>Sandeep Raghuraman</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In some cases, an empty string is returned by some of the functions like QDateTime::toString. Will this cause a crash? Is that what you're talking about?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope. I dug into Podcast classes, you really don't need to worry about this fields (artist, album, etc). Empty string can not cause any crash, I worried about null-pointers returned by artist() and album().</pre>
<br />
<p>- Sergey</p>
<br />
<p>On March 6th, 2011, 7:23 p.m., Sandeep Raghuraman wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Bart Cerneels.</div>
<div>By Sandeep Raghuraman.</div>
<p style="color: grey;"><i>Updated March 6, 2011, 7:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a dialog to configure podcast episode filenames. Added a filenamelayout column to podcastchannels table and a member to PodcastMeta to hold the filename layout. Podcast database version updated to 5.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=155075">155075</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp <span style="color: grey">(de53d77)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.h <span style="color: grey">(5bda713)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(777825e)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(9784d08)</span></li>
<li>src/core/podcasts/PodcastMeta.h <span style="color: grey">(e11b2eb)</span></li>
<li>src/core/podcasts/PodcastMeta.cpp <span style="color: grey">(fb82fa8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100686/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>