<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100405/">http://git.reviewboard.kde.org/r/100405/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2011, 10:09 p.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Feature seems useful and code looks good.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you please commit for me---I don't have the necessary access. Thanks!</pre>
<br />
<p>- Armin</p>
<br />
<p>On January 17th, 2011, 3:49 a.m., Armin Straub wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Armin Straub.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2011, 3:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new Track Progression mode which works like "Normal" except that it doesn't keep playing items from the playlist; instead it plays the queued items and then stops.
Motivation:
Most of the time I start playing a track (and maybe queue a few more) but immediately choose "Stop playing after current track". With the mode added in this patch, this last step becomes unnecessary.
Issues:
As an icon (see screenshot) for this mode, I have just reused the icon for the "Normal" mode. Maybe something like the icon for "Edit Queue" would be more appropriate. (This is in: src/playlist/navigators/NavigatorConfigAction.cpp)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarokconfig.kcfg <span style="color: grey">(b1672f3)</span></li>
<li>src/dbus/mpris2/Mpris2DBusHandler.cpp <span style="color: grey">(2bb4dd3)</span></li>
<li>src/playlist/PlaylistActions.cpp <span style="color: grey">(ee40bed)</span></li>
<li>src/playlist/navigators/NavigatorConfigAction.h <span style="color: grey">(e40dd1c)</span></li>
<li>src/playlist/navigators/NavigatorConfigAction.cpp <span style="color: grey">(d665fa8)</span></li>
<li>src/playlist/navigators/StandardTrackNavigator.h <span style="color: grey">(8e1d9ea)</span></li>
<li>src/playlist/navigators/StandardTrackNavigator.cpp <span style="color: grey">(429b915)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100405/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100405/s/47/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/17/onlyqueue_400x100.png" style="border: 1px black solid;" alt="Track Progression Modes" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>