<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100723/">http://git.reviewboard.kde.org/r/100723/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 25th, 2011, 5:36 p.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure about the need to abort the QMs. The QM -> model communication is exclusively via slots. disconnecting the qm's signals should prevent any message from reaching the model.
Otherwise the patch makes a lot of sense and should be merged asap.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Concerning the QM abort: After I found the "-nofork"-trick, I got a backtrace of the crashes. They happened here:
#0 0x00007ffff6bbd0a0 in Collections::ServiceSqlQueryMaker::handleResult (this=0x1a27360, result=...) at /home/amarokdev/workspace/amarok/src/services/ServiceSqlQueryMaker.cpp:613
#1 0x00007ffff6bbf293 in ServiceSqlWorkerThread::run (this=0x1a1d640) at /home/amarokdev/workspace/amarok/src/services/ServiceSqlQueryMaker.cpp:58
#2 0x00007ffff24441c1 in ThreadWeaver::JobRunHelper::runTheJob (this=0x7fffbb70cd30, th=0x144a490, job=0x1a1d640) at ../../../threadweaver/Weaver/Job.cpp:106
[...]
The way I see it, the running query is not stopped, when the query maker is deleted. So, when the query finishes, the query maker is still called to handle the result, which then leads to a crash. I think deleting an object, that is being used in another thread, without finishing this thread, might not be thread save.
Of course, the aborting of the query could also be done in the destructor of the QM, if necessary.</pre>
<br />
<p>- Wolfgang</p>
<br />
<p>On February 25th, 2011, 1:16 p.m., Wolfgang Lorenz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Wolfgang Lorenz.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2011, 1:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">patch for https://bugs.kde.org/show_bug.cgi?id=233170
When a query is started the Collections::QueryMaker* is stored in
QHash<CollectionTreeItem*, Collections::QueryMaker*> runningQueries.
Now, when CollectionTreeItemModelBase::populateChildren deletes items
CollectionTreeItemModelBase::itemAboutToBeDeleted
is called, which in turn stops, disconnects and deletes the queryMaker associated with the item.
The problem occurs, if there is more than one queryMaker for the item, as will happen, when
CollectionTreeItemModelBase::handleCompilations
is called. In this case itemAboutToBeDeleted deletes only one queryMaker. The other one finishes normally, calls
CollectionTreeItemModelBase::queryDone,
which in turn calls
CollectionTreeItem::row
of a deleted item and Amarok crashes with a segfault.
The patch changes the runningQueries buffer to QMultiHash. So all queryMakers are kept and itemAboutToBeDeleted can stop them all.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sometimes Amarok still crashed, when entering a search. Unfortunately, the backtrace was always empty in these cases. I don't know why. This could be another bug.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=233170">233170</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/CollectionTreeItemModelBase.h <span style="color: grey">(df260d6)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(9e5a50d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100723/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>