<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100630/">http://git.reviewboard.kde.org/r/100630/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 13th, 2011, 7:36 a.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some times I get several copies of 1 track in newer generated playlist (very rarely in random mode, and frequently with match by rating - my collection is very bad rated, so there are not so many tracks to choose from). I can't say is It appeared in this branch or It It's old bug (or not a bug at all), I'v never used dynamic playlists before. Also I can't understand how does "Quiz paly" works. Anyways 2nd day of tests and I haven't seen any errors, or bugs (except mentioned above).</pre>
</blockquote>
<p>On February 13th, 2011, 7:49 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Sergey,
use the "unique" bias to filter out duplicate tracks.
Quiz Play picks a track that starts with the character the last one ended with.
So after "Ronda" you get "All at once" and then "Every breath you take".
(you can also set this to use the artist instead of the track title)
The Biases have tool tips.</pre>
</blockquote>
<p>On February 14th, 2011, 10:03 a.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, thank you didn't know that. I just think that It shouldn't be separate mode, since usually users don't want to see duplicates in their playlist, especially a lot of copies of 1 track. I've got 10 copies of 1 song (entire playlist) when tried to use strict enough filter.
Btw, got a crash when tried to abort Echonest request, but once again I'm completely not sure that It appeared in this branch.
http://pastebin.com/0SRUCCZw</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I could reproduce the crash and fixed it.
Regarding Unique-songs.
I thought about it. I agree that usually you don't want to have duplicate tracks. However if you have a very selective Bias then duplicate tracks are the only correct result. However it should not end up like it was with the old Dynamic bias where it was quite likely that two tracks next to each other were duplicates.
For now I think that a separate "unique" bias is at least better than the old way where there was no way to prevent duplicates.
</pre>
<br />
<p>- Ralf</p>
<br />
<p>On February 11th, 2011, 5:19 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2011, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fix (actually not the attached patch but the dynamicplaylist branch) changes most of the dynamic playlist.
Main parts are the UI which was seen as confusing by many users and produced unexpected results.
The global bias is now a "part" bias which allows you to set a part of the collection matching a criteria.
The custom bias is now part of the bias system. I converted all existing custom biases to the new interface just to make sure that it's usable.
The fuzzy bias was completely removed. If someone really wants to have a bias which results in a normal distribution of one numeric value then please feel free to add it again. For now you can define this kind of bias by defining something like this "(rating > 1) AND (rating < 4)"
The branch needs to be merged back to mainline and might have conflicts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used it for a couple of times and wrote new auto tests.
Tested against bug reports.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=175163">175163</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=175172">175172</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=177627">177627</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=188360">188360</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=188360">188360</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=228738">228738</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=230773">230773</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=232673">232673</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=233859">233859</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=260001">260001</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=260003">260003</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=265191">265191</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=and">and</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=more">more</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=probably">probably</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=some">some</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(809d5e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100630/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>