<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100607/">http://git.reviewboard.kde.org/r/100607/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems reasonable enough to me. Especially since JsonQt was used because it was already hanging around in the source tree, and availability of friendly JSON libraries in package repos wasn't what it is today. However, if the PlaydarCollection didn't start up automatically and you had Playdar running on your system, then something's broken.</pre>
<br />
<p>- Andy</p>
<br />
<p>On February 8th, 2011, 12:17 a.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2011, 12:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What I did:
-) added cmake/modules/FindQJson.cmake
-) deleted external/JsonQt & adapted external/CmakeLists.txt
-) use QJson in collections/playdarcollection/support/
Why:
QJson is available via Package on pretty much every System now
Why QJson instead JsonQt? libmygpo-qt uses it, libechonest uses it and both Libraries will (sooner or later) be used in Amarok</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiled & run Amarok; didn't specifically try out Playdarcollection, didn't know how to "activate" it</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(11d4c9d5a296560f1c779e1dee4405c9827dac91)</span></li>
<li>README <span style="color: grey">(d8c142968c2da3888a703cc2b2e38d854f5c868b)</span></li>
<li>cmake/modules/FindQJSON.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/CMakeLists.txt <span style="color: grey">(0e161c701e0d1a9d7b769a1dda742df9e8f303ae)</span></li>
<li>external/JsonQt/CMakeLists.txt <span style="color: grey">(9978895bb72fa4993a4326397fa7284c74fd00ee)</span></li>
<li>external/JsonQt/COMPATIBILITY <span style="color: grey">(1a5b6195ca32395657535bd426a91a8a8ee5c22f)</span></li>
<li>external/JsonQt/COPYING.HEADER <span style="color: grey">(bf9c30eb90c5aa3c04a87a010736bb1c64326885)</span></li>
<li>external/JsonQt/Doxyfile.cmake <span style="color: grey">(4d2a4bf7035976f1cd06dcd43a55cb8ab660e47d)</span></li>
<li>external/JsonQt/README.txt <span style="color: grey">(4ebcf735ccbff8556914ed687b27f065dfb4a229)</span></li>
<li>external/JsonQt/add-copyright-header.sh <span style="color: grey">(8d21c92fbfa305e0f24d57e9a921235f624aecba)</span></li>
<li>external/JsonQt/lib/CMakeLists.txt <span style="color: grey">(3d394572d1af6b062ff6fb10881e462b5b4f7f9e)</span></li>
<li>external/JsonQt/lib/JsonQtExport.h <span style="color: grey">(30d5a7569710d4c31d9deffe3798566008fe89bc)</span></li>
<li>external/JsonQt/lib/JsonRpc.h <span style="color: grey">(8f0024c03c0c89c021f271421821e57b3d4b9367)</span></li>
<li>external/JsonQt/lib/JsonRpc.cpp <span style="color: grey">(cbcd16156ac44a55b7c34aae3d2b47b2b776f856)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptor.h <span style="color: grey">(83836c810358b7b5db44d151c6840027ec85586a)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptor.cpp <span style="color: grey">(18a1504435040a1cb8e6a785ae8093ade7d232ef)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptorPrivate.h <span style="color: grey">(03c990ce187ff90ccb591052f25de547e5651982)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptorPrivate.cpp <span style="color: grey">(c8fddb012b45c6117e5ac74b7d36cfa6c02048b1)</span></li>
<li>external/JsonQt/lib/JsonToProperties.h <span style="color: grey">(f04bd586e5d1aae9727d8bc4e218171954d86ec5)</span></li>
<li>external/JsonQt/lib/JsonToProperties.cpp <span style="color: grey">(4859d49b643bcd2e9cfb54c0c64581c94654b3f4)</span></li>
<li>external/JsonQt/lib/JsonToVariant.h <span style="color: grey">(82b62c0446b03df25aabcbd508fd24e290a9ac98)</span></li>
<li>external/JsonQt/lib/JsonToVariant.cpp <span style="color: grey">(323e31adfe0558d9b4dd671b7a9409cb9bb202fa)</span></li>
<li>external/JsonQt/lib/ParseException.h <span style="color: grey">(2f6566099bc13ab84eba28054330bcb0812e9785)</span></li>
<li>external/JsonQt/lib/ParseException.cpp <span style="color: grey">(c663179388f193175febe0eaaca6a2ce8241c215)</span></li>
<li>external/JsonQt/lib/VariantToJson.h <span style="color: grey">(2a1a645e4743af267ce21b55d7c164ea2805940b)</span></li>
<li>external/JsonQt/lib/VariantToJson.cpp <span style="color: grey">(baa7cddb548f10e6ea25e1b194683de7863055fc)</span></li>
<li>external/JsonQt/tests/CMakeLists.txt <span style="color: grey">(4954fe78d726afc534b541cd97c79551f40f742a)</span></li>
<li>external/JsonQt/tests/JsonRpc.cpp <span style="color: grey">(1ce4c9c59f5739426adbb3ed3ddaf148a3081a50)</span></li>
<li>external/JsonQt/tests/JsonRpcAdaptor.cpp <span style="color: grey">(6e995993c5683f64a8313e97ba4ec687032fc98a)</span></li>
<li>external/JsonQt/tests/JsonToProperties.cpp <span style="color: grey">(e1a0707737dd8051e601283cc0b0069894a095bd)</span></li>
<li>external/JsonQt/tests/JsonToVariant.cpp <span style="color: grey">(414d1c9c0e8da5f1a9a651ddd6a2e2da04395f4e)</span></li>
<li>external/JsonQt/tests/VariantToJson.cpp <span style="color: grey">(dfad043d13b25508785bace2277f3ac24d8dd2d5)</span></li>
<li>src/core-impl/collections/playdarcollection/CMakeLists.txt <span style="color: grey">(589ab02a8a1a09acdd2289c028fbca7b521b0e6a)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Controller.cpp <span style="color: grey">(f8e78055115f8ff38673c5eba0d493b53a000fa2)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Query.cpp <span style="color: grey">(4815d362a50344c7d1936fe0a98536577393a372)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100607/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>