<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100582/">http://git.reviewboard.kde.org/r/100582/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2011, 9:21 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100582/diff/1/?file=8495#file8495line116" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/podcasts/gpodder/GpodderProvider.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">PodcastEpisodePtr GpodderProvider::addEpisode(PodcastEpisodePtr episode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">116</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//</span><span class="cs">TODO</span><span class="c1"> ??????</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This method is also used to synchronize status between the default provider and gpodder. If you don't have the episode yet, add it to gpodder. If you do, update the status.</pre>
</blockquote>
<p>On February 6th, 2011, 2 p.m., <b>Stefan Derkits</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Bart for Clarification ....do you mean 1) adding an episode to gpodder.net or 2) adding an episode to the GpodderProvider? Cause "adding" it to gpodder.net is not really support, but of course updating the Status is (but we don't think that we will finish this in the first Version of the Provider & Service.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not clear on this. Does the gpodder.net server also parse RSS so it can know about the episodes? Or is it the clients that let gpodder.net know?
In the second case adding new episodes to gpodder indeed does not happen, just syncing status.</pre>
<br />
<p>- Bart</p>
<br />
<p>On February 5th, 2011, 10:22 p.m., Stefan Derkits wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Leo Franchi and Bart Cerneels.</div>
<div>By Stefan Derkits.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2011, 10:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Info about gpodder.net: "gpodder.net is a web service to manage your podcast subscriptions via the web. You can synchronize your devices, view status information and discover new interesting podcasts online."
Note: not yet ready for integration, only wanted to already open the Review Request to make our work more public and get Feedback
Additional Note: we've pulled the branch stecchino-IncrementalOpmlDirectory into our Branch ... so the Files related to Opml & the OpmlDirectory are not "up for Review" here and will be removed from the diff sometime in the Future ;)
Additional Dependency for this Service: libmygpo-qt (http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.0.10.tar.gz or https://github.com/ase23/libmygpo-qt)
What is added by this Service:
-) a new ServicePlugin with a Config Dialog for gpodder.net Username (synchronise checkbox doesn't do anything at the moment)
-) a gpodder Entry (internet/gpodder) where you can find the TopTags & TopPodcasts of these Tags from gpodder.net (not many Tags & Podcast per Tag yet, after testing is done we will set it to 50 or 100)
-) a PodcastProvider that should display the Podcasts subscribed to on gpodder.net and be able to add a Subscription to gpodder.net (subscribing doesn't work yet and displaying has some Bugs)
What Features will come in the Future:
-) display Podcast Data from gpodder.net
-) synchronization of Episode Status (if you listen to an Episode on your phone, it should show up in Amarok as "not new")
-) synchronization of Listening Status (you start to listen to an Episode in Amarok, finish it halfways, click pause/stop and </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">some testing done but still tons of bugs ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(b0ad614ce230efbcfcf4f2a84ee7b499caa09116)</span></li>
<li>CMakeLists.txt <span style="color: grey">(11d4c9d5a296560f1c779e1dee4405c9827dac91)</span></li>
<li>README <span style="color: grey">(d8c142968c2da3888a703cc2b2e38d854f5c868b)</span></li>
<li>cmake/modules/FindLibmygpo-qt.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(013021ca4049891685c898249db3055adc563bda)</span></li>
<li>src/OpmlOutline.h <span style="color: grey">(8b64dc1c798215e8edbd9081bcd9003a1fe8046e)</span></li>
<li>src/OpmlOutline.cpp <span style="color: grey">(5a3d6532b7d06524aeea30705b32fed04426c50e)</span></li>
<li>src/OpmlParser.h <span style="color: grey">(28c6c0c1d3ec904f418ef6115bc70258e8badd4a)</span></li>
<li>src/OpmlParser.cpp <span style="color: grey">(017c6c28c16079ac62f5a6fc10b225458b26d38e)</span></li>
<li>src/OpmlWriter.h <span style="color: grey">(c28e76dc73fb575abbc0d8255f0a1d55ca2b5969)</span></li>
<li>src/OpmlWriter.cpp <span style="color: grey">(13a9bf8196ed2a2d0ec48ba552103badca9f5236)</span></li>
<li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: grey">(c54ba251d3ebcbef83b7f44110bca5e5a846cd98)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/gpodder/GpodderProvider.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: grey">(9784d089292dd8dc35854570db46a801b3daaf16)</span></li>
<li>src/images/CMakeLists.txt <span style="color: grey">(20149eb59120cc5711610908dce8f836d8f0abe3)</span></li>
<li>src/images/emblem-gpodder-scalable.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/emblem-gpodder.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/icons/hi16-action-view-services-gpodder-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/icons/hi22-action-view-services-gpodder-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/icons/hi32-action-view-services-gpodder-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/icons/hi48-action-view-services-gpodder-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/icons/svg/action-view-services-gpodder-amarok.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/CMakeLists.txt <span style="color: grey">(1de81f6fb542d3b9046c408d092c16812724f415)</span></li>
<li>src/services/gpodder/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderPodcastTreeItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderPodcastTreeItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderServiceView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTagTreeItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTagTreeItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTreeItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/GpodderTreeItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/amarok_service_gpodder.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/amarok_service_gpodder_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/images/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/gpodder/images/mygpo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/AddOpmlWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/CMakeLists.txt <span style="color: grey">(0ad1a93ce03cda502fa56999922e64e48da8e757)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryDelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryDelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryService.h <span style="color: grey">(978280a36085d8738bb855d76d1aa024d3bc0303)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryService.cpp <span style="color: grey">(735b8c0c49abcb0806179aef3d95be92358075b2)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/OpmlDirectoryView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/services/opmldirectory/podcast_directory.opml <span style="color: grey">(PRE-CREATION)</span></li>
<li>supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-kdesupport.install <span style="color: grey">(bd570753a0648159935e0c7c12c325f7b5206d9c)</span></li>
<li>supplementary_scripts/neon/distros/ubuntu/kdesupport-debian/kde-nightly-kdesupport.install <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100582/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>