<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100270/">http://git.reviewboard.kde.org/r/100270/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, this patch looks good to me, I'm in favor of pushing it to Git Master. Maximilian, do you have push access to KDE Git? If not, we can push it for you.
PS:
Looking at this screenshot, I can't help noticing that the GUI has serious issues (not the changes that this patch introduced, but generally). What's it with the ugly bold borders around those buttons at the top? We should really clean that up...
</pre>
<br />
<p>- Mark</p>
<br />
<p>On January 20th, 2011, 11 p.m., Maximilian Güntner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Maximilian Güntner.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2011, 11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds manual preview functionality to the collection organizer dialog. This is very handy when altering the filename scheme and options of large collections ( > 1k files) since the dialog doesn't update the preview widget with every change in the filename configurator. The current functionality can be achieved by clicking on "Automatic Preview". Hope you like it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-tested auto update by using/clicking each element that connects to the signalmapper
-tested the manual preview button
-moved a collection</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: grey">(a104c8e)</span></li>
<li>src/dialogs/OrganizeCollectionDialogBase.ui <span style="color: grey">(2f28102)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100270/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100270/s/31/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/12/30/amarok_patch_400x100.png" style="border: 1px black solid;" alt="Preview Button and auto preview checkbox" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>