<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100191/">http://git.reviewboard.kde.org/r/100191/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still works, and still has functional advantages over current MetaTagLib implementation. :)</pre>
<br />
<p>- Sergey</p>
<br />
<p>On January 12th, 2011, 1:58 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2011, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite tag reading stuff to make It more OOP way. Add separate classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4). Exclude almost all "magic words" (frame/field names) from code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on small test collection of mp3, ogg, flac, mpc, m4a, wav, wma files. Also tested setting/getting of covers (mp3 - ID3v2, m4a - MP4, wma - ASF). Everything seems to work fine. Tag guesser works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(dc5e57b)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(63d81c7)</span></li>
<li>shared/MetaTagLib.h <span style="color: grey">(ff27c92)</span></li>
<li>shared/MetaTagLib.cpp <span style="color: grey">(90e2483)</span></li>
<li>shared/TagsFromFileNameGuesser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(5dd4163)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(9f1df54)</span></li>
<li>src/dialogs/FilenameLayoutDialog.h <span style="color: grey">(0380cc1)</span></li>
<li>src/dialogs/FilenameLayoutDialog.cpp <span style="color: grey">(0efd23d)</span></li>
<li>src/dialogs/FilenameLayoutDialog.ui <span style="color: grey">(e75f407)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(70360ff)</span></li>
<li>src/dialogs/TagGuesser.h <span style="color: grey">(c3cc89f)</span></li>
<li>src/dialogs/TagGuesser.cpp <span style="color: grey">(869f432)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(78a07a6)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey">(6be9319)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100191/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100191/s/25/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/12/20/TagGuesser_400x100.png" style="border: 1px black solid;" alt="TagGuesser with full filepath" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>