<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100321/">http://git.reviewboard.kde.org/r/100321/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that It's a bad idea to apply any settings when user press Cancel, so storing Format Presets should stay in onAccept slot.
Agree with second statement.
And finally this patch has nothing in common with mentioned Bug Report.</pre>
<br />
<p>- Sergey</p>
<br />
<p>On January 8th, 2011, 11:11 a.m., Philipp Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Philipp Schmidt.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2011, 11:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes two errors:
First: Presets are being saved explicitely, meaning they should persist even when the Dialog is aborted/canceled.
Second: The state of the Current Collection Directory is saved regardless of whether the Dialog was accepted or canceled. IMO it should only be saved like all other values when it is accepted.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=255325">255325</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(3c337d1)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: grey">(b7d7850)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100321/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>