<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100285/">http://git.reviewboard.kde.org/r/100285/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Rick W. Chen.</div>
<div>By Martin Blumenstingl.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently NetworkAccessManagerProxy::getData() ignores redirects.
Since redirects are required for some URLs (see the linked bug) it would be nice if Amarok's NetworkAccessManagerProxy would also support them.
Please have a look at my comments below, I'm trying to explain some of the issues there.
Here's a quick overview of my changes:
-I implemented redirection support
-Infinite loops are currently not handled properly, if page A redirects to itself my code will not do the redirect.
But my code does not handle "if page A redirects to page B which redirects to page A"-loops.
-I tried to test the changes in CoverFetcher but I couldn't find anything that uses redirects there.
Thus those changes are basically "untested".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested Sven's "Free Music Charts" script: it works fine now.
Fetching lyrics through the "Ultimate Lyrics" script is also still working.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=261839">261839</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/covermanager/CoverFetcher.h <span style="color: grey">(9dc2f2e)</span></li>
<li>src/covermanager/CoverFetcher.cpp <span style="color: grey">(b21dd87)</span></li>
<li>src/network/NetworkAccessManagerProxy.h <span style="color: grey">(045ded3)</span></li>
<li>src/network/NetworkAccessManagerProxy.cpp <span style="color: grey">(9a0e763)</span></li>
<li>src/scriptengine/AmarokNetworkScript.h <span style="color: grey">(342cc2a)</span></li>
<li>src/scriptengine/AmarokNetworkScript.cpp <span style="color: grey">(1742f41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>