<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100191/">http://git.reviewboard.kde.org/r/100191/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 6th, 2010, 12:50 p.m., <b>Jeff Mitchell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't tell from the diff if charset detector is on by default with your new patch, but it shouldn't be.
It causes far more problems than it solves, which is why people have to explicitly request it now.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope, there is no charset detector at all.</pre>
<br />
<p>- Sergey</p>
<br />
<p>On December 5th, 2010, 2:47 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-12-05 14:47:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite tag reading stuff to make It more OOP way. Add separat classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code.
TODO:
Implement charset detection stuff.
Complete ASF tags. Implement embedded covers support for MP4 files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(dc5e57b)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(63d81c7)</span></li>
<li>shared/MetaTagLib.h <span style="color: grey">(ff27c92)</span></li>
<li>shared/MetaTagLib.cpp <span style="color: grey">(f74df21)</span></li>
<li>shared/TagsFromFileNameGuesser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(9ac230e)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(78a07a6)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey">(6be9319)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100191/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>