<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100182/">http://git.reviewboard.kde.org/r/100182/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, and works for me.</pre>
<br />
<p>- Sergey</p>
<br />
<p>On December 1st, 2010, 5:06 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated 2010-12-01 17:06:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove addMatchTo and addMatch( Meta::DataPtr )
Both functions were effectively used at only one place but were implemented at several places.
Removing the functions cleans up the api.
Summary:
32 files changed, 47 insertions(+), 229 deletions(-)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Auto tests and playing around with collection view.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/CollectionTreeItem.h <span style="color: grey">(c7748d1)</span></li>
<li>src/browsers/CollectionTreeItem.cpp <span style="color: grey">(770c8fe)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(6f76380)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: grey">(cc4d93e)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(967b742)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.h <span style="color: grey">(3fdf8f4)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: grey">(ff03431)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h <span style="color: grey">(307a5c6)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp <span style="color: grey">(9a2bbbe)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h <span style="color: grey">(fdd62c0)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp <span style="color: grey">(2e913e4)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h <span style="color: grey">(c825f65)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp <span style="color: grey">(e8a26dd)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.h <span style="color: grey">(1d11435)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: grey">(d413d18)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.h <span style="color: grey">(e3d2c35)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.cpp <span style="color: grey">(ec75198)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.h <span style="color: grey">(234f337)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(68c11dd)</span></li>
<li>src/core/collections/MetaQueryMaker.h <span style="color: grey">(9c1d0ba)</span></li>
<li>src/core/collections/MetaQueryMaker.cpp <span style="color: grey">(d09950f)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: grey">(409dc85)</span></li>
<li>src/core/meta/Meta.h <span style="color: grey">(de9d193)</span></li>
<li>src/core/meta/Meta.cpp <span style="color: grey">(b5f4002)</span></li>
<li>src/services/DynamicServiceQueryMaker.h <span style="color: grey">(7a8a9e8)</span></li>
<li>src/services/DynamicServiceQueryMaker.cpp <span style="color: grey">(f47a6f9)</span></li>
<li>src/services/ServiceSqlQueryMaker.h <span style="color: grey">(dc586f0)</span></li>
<li>src/services/ServiceSqlQueryMaker.cpp <span style="color: grey">(93a3cef)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.h <span style="color: grey">(d68e303)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: grey">(f4c7333)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlQueryMaker.h <span style="color: grey">(f3c3d2c)</span></li>
<li>tests/core-impl/collections/db/sql/TestSqlQueryMaker.cpp <span style="color: grey">(98990d5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100182/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>