<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100177/">http://git.reviewboard.kde.org/r/100177/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Andreas Hartmetz.</div>
<p style="color: grey;"><i>Updated 2010-11-29 17:49:53.425707</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commit messages of this updated diff:
- Queue Editor: Fix clear button icon. Make initial size smaller.
- Show artist *and* track for songs in the queue editor
- Update the queue editor on track progression
- Don't use an index that is strictly speaking invalid after reloading
the queue list view, use the quint 64 id. Restore the current item also
after responding to externally generated queue changes.
- More suitable and better looking initial size for queue editor.
The aspect ratio is roughly the golden ratio :)
- Update the playlist on changes in the queue editor
- Codingstyle: return types on their own lines
- Put the edit queue action next to the other actions in the middle
- Use a more suitable icon for the queue editor action</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a Queue Editor, with limited features (move up / move down / clear) like in Amarok 1.
The KAction for it is not very well placed in the main UI, I hope you guys can help me.
A few design changes were necessary, too, as you can see in the patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"worksforme"</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=198180">198180</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(c5ee1e3)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(f755b6f)</span></li>
<li>src/likeback/LikeBackBar.cpp <span style="color: grey">(6964f88)</span></li>
<li>src/playlist/PlaylistActions.h <span style="color: grey">(a0b2275)</span></li>
<li>src/playlist/PlaylistActions.cpp <span style="color: grey">(d9284e7)</span></li>
<li>src/playlist/PlaylistController.cpp <span style="color: grey">(f05c250)</span></li>
<li>src/playlist/PlaylistDock.h <span style="color: grey">(f7f1231)</span></li>
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(6170f78)</span></li>
<li>src/playlist/PlaylistItem.h <span style="color: grey">(6bfeb68)</span></li>
<li>src/playlist/PlaylistModel.h <span style="color: grey">(7b7633f)</span></li>
<li>src/playlist/PlaylistModel.cpp <span style="color: grey">(0162321)</span></li>
<li>src/playlist/PlaylistQueueEditor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlist/PlaylistQueueEditor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlist/PlaylistQueueEditor.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlist/navigators/DynamicTrackNavigator.cpp <span style="color: grey">(a1c67e7)</span></li>
<li>src/playlist/navigators/StandardTrackNavigator.cpp <span style="color: grey">(faeb9f7)</span></li>
<li>src/playlist/navigators/TrackNavigator.h <span style="color: grey">(6154f9a)</span></li>
<li>src/playlist/navigators/TrackNavigator.cpp <span style="color: grey">(2a70b08)</span></li>
<li>src/playlist/proxymodels/AbstractModel.h <span style="color: grey">(03ca4d6)</span></li>
<li>src/playlist/proxymodels/ProxyBase.h <span style="color: grey">(2e6f9e7)</span></li>
<li>src/playlist/proxymodels/ProxyBase.cpp <span style="color: grey">(37cb8cb)</span></li>
<li>src/playlist/view/PlaylistViewCommon.cpp <span style="color: grey">(2a5c9f6)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: grey">(5494279)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: grey">(0b2e41e)</span></li>
<li>src/statusbar/StatusBar.cpp <span style="color: grey">(1a67677)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100177/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>