<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100169/">http://git.reviewboard.kde.org/r/100169/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've been thinking about It, but you made It first. :)</pre>
<br />
<p>- Sergey</p>
<br />
<p>On November 25th, 2010, 11:12 a.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated 2010-11-25 11:12:25</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move the slightly different code for tag reading and writing into one file.
Benefit:
- amarok collection scanner and Meta::FileTrack will behave the same.
- easier to keep reading and writing in sync
- less code to maintain
20 files changed, 1424 insertions(+), 3137 deletions(-)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Auto tests and collection scanner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/MetaTagLib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/MetaTagLib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/MetaValues.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3a0ac94)</span></li>
<li>src/core-impl/collections/db/DatabaseMeta.cpp <span style="color: grey">(d19bc5b)</span></li>
<li>src/core-impl/collections/db/sql/CMakeLists.txt <span style="color: grey">(2b82b2b)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(5ababa0)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(f620767)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(b66bd25)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(443cf27)</span></li>
<li>src/core-impl/meta/file/TagLibUtils.h <span style="color: grey">(9d0fd8c)</span></li>
<li>src/core-impl/meta/file/TagLibUtils.cpp <span style="color: grey">(ea72626)</span></li>
<li>src/core/meta/support/MetaConstants.h <span style="color: grey">(b63e530)</span></li>
<li>tests/core-impl/collections/sqlcollection/CMakeLists.txt <span style="color: grey">(7627c41)</span></li>
<li>tests/core-impl/collections/sqlcollection/TestSqlQueryMaker.cpp <span style="color: grey">(eb2d5db)</span></li>
<li>tests/mocks/AftUtilityMock.cpp <span style="color: grey">(2ff92d3)</span></li>
<li>utilities/collectionscanner/AFTUtility.h <span style="color: grey">(b211569)</span></li>
<li>utilities/collectionscanner/AFTUtility.cpp <span style="color: grey">(85e2364)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey">(a368981)</span></li>
<li>utilities/collectionscanner/Track.h <span style="color: grey">(47434ff)</span></li>
<li>utilities/collectionscanner/Track.cpp <span style="color: grey">(0df0b7d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100169/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>