<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100168/">http://git.reviewboard.kde.org/r/100168/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch. I'm sure this feature will be much loved by many amarok users. I do have one big request:
Currently this code is only used when a playlist is saved in the database. This is only one, albeit the default, playlistprovider. We also support saving to a playlist-file (in the $KDEHOME/share/apps/amarok/playlists) and to attached media players. In the future we will be able to save a playlist to online services as well.
Looking at the code there is no single SQL specific function used, hence this is just a cut and paste job.
In short: I want this function moved to outside the SqlPlaylist classes and into the playlist-view, perhaps PlaylistModel.cpp, so it can be called from Playlist::Dock::slotSaveCurrentPlaylist().
When integrating this patch I'll also change the export playlist functionality to do the same.</pre>
<br />
<p>- Bart</p>
<br />
<p>On November 25th, 2010, 1:01 a.m., Dennis Francis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Dennis Francis.</div>
<p style="color: grey;"><i>Updated 2010-11-25 01:01:23</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The playlist name is generated as per the rules :
if ( singleArtist && singleAlbum )
playlistName = artist + " - " + album + ' - ' + shortDate
else if ( !singleArtist && singleAlbum )
playlistName = "Various" + " - " + album + ' - ' + shortDate
else if ( singleArtist && !singleAlbum )
playlistName = artist + " - " + "Various" + shortDate
else
playlistName = "Various" + " - " + shortDate
If the there are no tracks, the playlist name is set to "Empty Playlist - " + shortDate
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested different possibilities. It is working fine for me.
Please suggest better alternatives ( if any ) to the shortDate addition. Without the shortDate, playlist database lookup would be necessary to
calculate a unique name.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=185397">185397</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlistmanager/sql/SqlUserPlaylistProvider.h <span style="color: grey">(3a5a62e)</span></li>
<li>src/playlistmanager/sql/SqlUserPlaylistProvider.cpp <span style="color: grey">(d2ae5b9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100168/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>