<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100156/">http://git.reviewboard.kde.org/r/100156/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100156/diff/1/?file=4074#file4074line1569" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">IpodHandler::libIsCompilation( const Meta::MediaDeviceTrackPtr &track )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1569</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="p">(</span> <span class="n">m_itdbtrackhash</span><span class="p">[</span> <span class="n">track</span> <span class="p">]</span><span class="o">-></span><span class="n">compilation</span> <span class="o">==</span> <span class="mh">0x0</span> <span class="p">)</span> <span class="o">?</span> <span class="kc">false</span> <span class="o">:</span> <span class="kc">true</span><span class="p">;</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can just return m_itdbtrackhash[ track ]->compilation.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good for me.</pre>
<p>- Sergey</p>
<br />
<p>On November 17th, 2010, 8:44 a.m., Albert Farres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Albert Farres.</div>
<p style="color: grey;"><i>Updated 2010-11-17 08:44:38</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compilations albums now are shown under Various Artists item on Ipod devices.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with one Ipod Classic (6th gen)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=207880">207880</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.h <span style="color: grey">(07e0380)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp <span style="color: grey">(cd50661)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.h <span style="color: grey">(44af297)</span></li>
<li>src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.cpp <span style="color: grey">(3825187)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp <span style="color: grey">(d2c5248)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.h <span style="color: grey">(abf98a0)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.cpp <span style="color: grey">(bbea5d0)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/MtpHandler.h <span style="color: grey">(095d3fa)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp <span style="color: grey">(f93eb99)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.h <span style="color: grey">(598ede2)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.cpp <span style="color: grey">(c95d43d)</span></li>
<li>src/core-impl/collections/umscollection/handler/UmsHandler.h <span style="color: grey">(70edc26)</span></li>
<li>src/core-impl/collections/umscollection/handler/UmsHandler.cpp <span style="color: grey">(c402c54)</span></li>
<li>src/core-impl/collections/umscollection/handler/capabilities/UmsReadCapability.h <span style="color: grey">(85f76d1)</span></li>
<li>src/core-impl/collections/umscollection/handler/capabilities/UmsReadCapability.cpp <span style="color: grey">(071d19e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100156/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>