<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100153/">http://git.reviewboard.kde.org/r/100153/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 15th, 2010, 9:56 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rick noticed that contextualActions were commented out.
That was a mistake. They need to be commented in again and all the actions need to be freed after finish like at all the other places.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I made a patch on top of your diff that renables the actions and frees them correctly at http://paste.pocoo.org/show/292821/.</pre>
<br />
<p>- Rick W.</p>
<br />
<p>On November 15th, 2010, 11:47 a.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated 2010-11-15 11:47:35</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename CustomActionsCapability to ActionsCapability
Use ActionsCapability also as CollectionsCapability
Use ActionsCapability as CurrentTrackActionsCapability
Move all Bookmark actions to the BookmarkThisCapability adding the check for it at several places.
Ensure that all created actions without a parent get one upon usage clearing several memory leaks.
Note: The cleanup gets rid of over 600 lines of code with (hopefully) unchanged functionality and better readability.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried all track/album/collection actions I could find.
Also with a audio cd (which has an eject action)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(12bb8f3)</span></li>
<li>src/TrayIcon.cpp <span style="color: grey">(f1b0f94)</span></li>
<li>src/browsers/CollectionTreeItem.h <span style="color: grey">(65f7d11)</span></li>
<li>src/browsers/CollectionTreeItem.cpp <span style="color: grey">(46a6326)</span></li>
<li>src/browsers/CollectionTreeView.h <span style="color: grey">(3cf4e70)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: grey">(2bb894c)</span></li>
<li>src/context/applets/albums/AlbumsView.cpp <span style="color: grey">(76a5bb3)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.h <span style="color: grey">(69a9f6b)</span></li>
<li>src/context/applets/currenttrack/CurrentTrack.cpp <span style="color: grey">(e48ac95)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollection.h <span style="color: grey">(fec9665)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollection.cpp <span style="color: grey">(d0979cf)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollectionCapability.h <span style="color: grey">(9becc6f)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdCollectionCapability.cpp <span style="color: grey">(18eac0b)</span></li>
<li>src/core-impl/collections/audiocd/CMakeLists.txt <span style="color: grey">(c45c670)</span></li>
<li>src/core-impl/collections/db/sql/CMakeLists.txt <span style="color: grey">(4be4c05)</span></li>
<li>src/core-impl/collections/db/sql/CapabilityDelegate.h <span style="color: grey">(28c8daa)</span></li>
<li>src/core-impl/collections/db/sql/CapabilityDelegateImpl.h <span style="color: grey">(ea84f74)</span></li>
<li>src/core-impl/collections/db/sql/CapabilityDelegateImpl.cpp <span style="color: grey">(fb33fb1)</span></li>
<li>src/core-impl/collections/db/sql/SqlBookmarkThisCapability.h <span style="color: grey">(9418f2f)</span></li>
<li>src/core-impl/collections/db/sql/SqlBookmarkThisCapability.cpp <span style="color: grey">(fbc41ba)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollection.h <span style="color: grey">(80b6495)</span></li>
<li>src/core-impl/collections/db/sql/SqlCollection.cpp <span style="color: grey">(5fb1bca)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.h <span style="color: grey">(3937660)</span></li>
<li>src/core-impl/collections/db/sql/SqlMeta.cpp <span style="color: grey">(1d70872)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.h <span style="color: grey">(5f690ad)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.cpp <span style="color: grey">(dc7aa9f)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionCapability.h <span style="color: grey">(67211f6)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionCapability.cpp <span style="color: grey">(40b9fff)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceDecoratorCapability.h <span style="color: grey">(1bcfc8b)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceDecoratorCapability.cpp <span style="color: grey">(a68a564)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(ec7f5e1)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukAlbum.cpp <span style="color: grey">(590a656)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: grey">(2628889)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(e170be2)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.cpp <span style="color: grey">(4640abf)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(a661e06)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(8272804)</span></li>
<li>src/core/capabilities/ActionsCapability.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/capabilities/ActionsCapability.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/capabilities/BookmarkThisCapability.h <span style="color: grey">(0b0a45b)</span></li>
<li>src/core/capabilities/BookmarkThisCapability.cpp <span style="color: grey">(14c5b44)</span></li>
<li>src/core/capabilities/Capability.h <span style="color: grey">(4057144)</span></li>
<li>src/core/capabilities/CollectionCapability.h <span style="color: grey">(003da1f)</span></li>
<li>src/core/capabilities/CollectionCapability.cpp <span style="color: grey">(e304034)</span></li>
<li>src/core/capabilities/CurrentTrackActionsCapability.h <span style="color: grey">(c2bd724)</span></li>
<li>src/core/capabilities/CurrentTrackActionsCapability.cpp <span style="color: grey">(d3e52c8)</span></li>
<li>src/core/capabilities/CustomActionsCapability.h <span style="color: grey">(91a403b)</span></li>
<li>src/core/capabilities/CustomActionsCapability.cpp <span style="color: grey">(11c44fb)</span></li>
<li>src/core/capabilities/DecoratorCapability.h <span style="color: grey">(1069e3e)</span></li>
<li>src/core/capabilities/DecoratorCapability.cpp <span style="color: grey">(35c855d)</span></li>
<li>src/covermanager/CoverManager.cpp <span style="color: grey">(25a69cb)</span></li>
<li>src/playlist/view/PlaylistViewCommon.h <span style="color: grey">(974f1bd)</span></li>
<li>src/playlist/view/PlaylistViewCommon.cpp <span style="color: grey">(81e0bdf)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: grey">(527dc84)</span></li>
<li>src/services/ServiceCapabilities.h <span style="color: grey">(7079bff)</span></li>
<li>src/services/ServiceCapabilities.cpp <span style="color: grey">(7188abd)</span></li>
<li>src/services/ServiceCollectionTreeView.cpp <span style="color: grey">(7ebc61b)</span></li>
<li>src/services/ServiceMetaBase.h <span style="color: grey">(178aaec)</span></li>
<li>src/services/ServiceMetaBase.cpp <span style="color: grey">(94cd025)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.h <span style="color: grey">(5c23452)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: grey">(444ceb6)</span></li>
<li>src/toolbar/CurrentTrackToolbar.cpp <span style="color: grey">(c180f90)</span></li>
<li>src/toolbar/MainToolbar.cpp <span style="color: grey">(e8dbd5b)</span></li>
<li>tests/core-impl/collections/sqlcollection/TestSqlAlbum.cpp <span style="color: grey">(3aeb575)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100153/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>