<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100135/">http://git.reviewboard.kde.org/r/100135/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-11-10 19:35:59.303372</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess this is final version. Looked over services, and, seems to me, that Sql-based collections - the only place where It could work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add new QueryType - AlbumArtist. Add new "level" to collection browser.
It works well with SqlCollection, still need to make It work for all services which support such queries.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with SqlCollection. Seems works for me. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/amarokurls/NavigationUrlGenerator.cpp <span style="color: grey">(5c48e73)</span></li>
<li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: grey">(2d6384b)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.h <span style="color: grey">(23a189f)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(280245a)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: grey">(2bb894c)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: grey">(8623079)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.h <span style="color: grey">(680050f)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMaker.cpp <span style="color: grey">(ca105e8)</span></li>
<li>src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp <span style="color: grey">(9002acf)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h <span style="color: grey">(63d6c2c)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp <span style="color: grey">(c17c3fd)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.h <span style="color: grey">(72ddaf1)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: grey">(81bf9b6)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMakerInternal.h <span style="color: grey">(db94d8b)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMakerInternal.cpp <span style="color: grey">(eeffd77)</span></li>
<li>src/core-impl/collections/support/XmlQueryReader.cpp <span style="color: grey">(b5518f0)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.h <span style="color: grey">(5caf7bc)</span></li>
<li>src/core-impl/collections/support/XmlQueryWriter.cpp <span style="color: grey">(3c9cf41)</span></li>
<li>src/core/collections/MetaQueryMaker.h <span style="color: grey">(799825a)</span></li>
<li>src/core/collections/MetaQueryMaker.cpp <span style="color: grey">(10ae2a7)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: grey">(9c15659)</span></li>
<li>src/core/collections/QueryMaker.cpp <span style="color: grey">(78c6ba7)</span></li>
<li>src/core/meta/support/MetaConstants.h <span style="color: grey">(73d03fc)</span></li>
<li>src/core/meta/support/MetaUtility.cpp <span style="color: grey">(5cf4519)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(fbc89ae)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(ddd73cb)</span></li>
<li>src/dialogs/TagDialogBase.ui <span style="color: grey">(816ecb5)</span></li>
<li>src/services/ServiceSqlQueryMaker.h <span style="color: grey">(5591ecc)</span></li>
<li>src/services/ServiceSqlQueryMaker.cpp <span style="color: grey">(197f2cf)</span></li>
<li>src/services/ampache/AmpacheServiceQueryMaker.cpp <span style="color: grey">(7dee8c8)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp <span style="color: grey">(4dc8fed)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: grey">(76faca2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100135/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100135/s/17/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/06/AA_400x100.png" style="border: 1px black solid;" alt="Only one album "Once". As It should be." /></a>
<a href="http://git.reviewboard.kde.org/r/100135/s/18/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/06/AA1_400x100.png" style="border: 1px black solid;" alt="2 albums, and 3rd is somewhere below." /></a>
<a href="http://git.reviewboard.kde.org/r/100135/s/19/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/06/AA_1_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>