<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100141/">http://git.reviewboard.kde.org/r/100141/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok and Mark Kretschmann.</div>
<div>By Andy Coder.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Drops QPointer in favor of QWeakPointer in src/core-impl/collections/playdarcollection, as was done for other code in [0] and recommended in [1].
Nothing works differently, but since it is, in number of changes at least, non-trivial, (and I've been fairly absent for a while), I figured I ought to put it up for review. In particular, anyone more familiar with QWeakPointer checking to see if I did something stupid that might cause hard to find problems down the road would be appreciated.
[0] - http://git.reviewboard.kde.org/r/100011/
[1] - http://git.reviewboard.kde.org/r/100001/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, ran, played around. Worked fine for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.h <span style="color: grey">(31aba11)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.cpp <span style="color: grey">(845d3fd)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.h <span style="color: grey">(2599b7c)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.cpp <span style="color: grey">(755191a)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h <span style="color: grey">(277a582)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp <span style="color: grey">(590c0d8)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Controller.h <span style="color: grey">(1db079a)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Query.h <span style="color: grey">(01971f7)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Query.cpp <span style="color: grey">(d586047)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100141/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>