<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100124/">http://git.reviewboard.kde.org/r/100124/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rest looks fine. I'd say ship it!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100124/diff/1/?file=3036#file3036line285" style="color: black; font-weight: bold; text-decoration: underline;">src/playlist/view/listview/PrettyListView.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">285</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">Playlist</span><span class="o">::</span><span class="n">PrettyListView</span><span class="o">::</span><span class="n">upOneTrack</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FYI: upOneTrack() copies most code from downOneTrack()
You should introduce something like navigateThroughTracks(int offset) and call that from both methods.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On November 1st, 2010, 12:36 p.m., Thomas Karpiniec wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Thomas Karpiniec.</div>
<p style="color: grey;"><i>Updated 2010-11-01 12:36:59</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This lets the user use up/down keys while keeping focus in the progressive search widget. The use case for this is particularly when "Show only matches" is checked: type in the first few letters of the track you're interested in, use arrow keys to select from a much smaller list, then press enter to play it and go back to a full playlist.
Previously, pressing down would give focus to the playlist which meant that pressing enter on a track would not clear the search box and the refined playlist would remain. IMHO it would be better to make this "temporary search-based playlist" behaviour explicit either by clicking focus to the playlist or by pressing TAB (this last part is something else I would like to add).
Overall I think this is a smoother and more consistent workflow for people like me who don't like to take their hands off the keyboard.
Also, my Qt experience is almost nil so any comments or suggestions regarding code style and approach would be much appreciated. Cheers!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The use of up & down has been tested to make sure that selection stays within bounds.
A good test of the index-setting which brought out some odd behaviour early on:
- Turn on "Show only matches"
- Use search and start a song playing by using up/down and enter
- Search again and type in a string which doesn't match the song playing
- Backspace it and type in a search which includes the current playing song plus others above it
- Make sure the top song is selected by default and pressing enter plays that one, not the already playing track
- Make sure that pressing down/up starts with the selection moving from the top, not the already playing track
And the same again, except don't ever let the currently playing song be filtered out.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(b0b725a)</span></li>
<li>src/playlist/ProgressiveSearchWidget.h <span style="color: grey">(310b37b)</span></li>
<li>src/playlist/ProgressiveSearchWidget.cpp <span style="color: grey">(4e7bc84)</span></li>
<li>src/playlist/view/listview/PrettyListView.h <span style="color: grey">(ffbd723)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: grey">(527dc84)</span></li>
<li>src/widgets/LineEdit.h <span style="color: grey">(dde6d5d)</span></li>
<li>src/widgets/LineEdit.cpp <span style="color: grey">(a76deaf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100124/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>