<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100127/">http://git.reviewboard.kde.org/r/100127/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 4th, 2010, 11:28 a.m., <b>Mark Kretschmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks great now. Many thanks for the improvements!
I think after the many fixes you made, this could go into Mainline. Best way to get more eyeballs on it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It still has one bug, It crash amarok some times (rarely, but happens). I have to fix It before. :)</pre>
<br />
<p>- Sergey</p>
<br />
<p>On November 4th, 2010, 11:20 a.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-11-04 11:20:27</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch->SearchResults. Search results sorted by similarity ratio ( more similar is on top ), and has different colors corresponding to that. MusicDNS search results marked with a cyan color and stay on bottom. There is no Start search button any more, both searches run simultaneously.
Will be Implemented soon:
1) DONE: If one TrackID founded by both searches, this result automatically moves on top.
2) DONE: MB icon linked to track page on musicbrainz.org.
3..n Needs your advices. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(9fcd33e)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: grey">(e33c9f6)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: grey">(cdc3ec5)</span></li>
<li>src/dialogs/MusicBrainzTagger.ui <span style="color: grey">(3f14236)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(e98acf5)</span></li>
<li>src/images/CMakeLists.txt <span style="color: grey">(7581267)</span></li>
<li>src/images/mb_aicon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/mb_licon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/images/mb_ticon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: grey">(49c8f6b)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(41ddbaa)</span></li>
<li>src/musicbrainz/MusicBrainzMeta.h <span style="color: grey">(57ed363)</span></li>
<li>src/musicbrainz/MusicBrainzTags.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTags.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: grey">(a93929a)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: grey">(1bf7389)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.h <span style="color: grey">(6eaa648)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.cpp <span style="color: grey">(fa1fc10)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: grey">(2cd00d1)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: grey">(9c31f38)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100127/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100127/s/12/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/02/MBT_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/100127/s/13/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/02/MBT1_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/100127/s/14/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/04/MBT_400x100.png" style="border: 1px black solid;" alt="Context menu" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>