<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100127/">http://git.reviewboard.kde.org/r/100127/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 1st, 2010, 7:21 p.m., <b>Stefan Derkits</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Colours in the Screenshot look a little bit strange (especially this really light blue) and could need some Refinement
And the Selection which Set of Tags to use should maybe be made by selecting it, instead of using checkboxes (because you can only select one tagset)
otherwise a good Improvement :)</pre>
</blockquote>
<p>On November 1st, 2010, 8:16 p.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to make gradient Red->Green ( through orange ), but It looked terrible, that's why I dropped blue color component. Color for MusicDNS was taken "from a roof", It's a simple Qt::cyan. They all can be changed, i.e. waiting for your advices. :)
I think that checkboxes much more clear for understanding of selection precess then simple row selection, and It prevents from: "WTF happened with my tags, I didn't mean to accept this crap!?"
Btw mass-selection still available by clicking on a first header column, It automatically select all top results, except tracks that already has result selected by user.</pre>
</blockquote>
<p>On November 1st, 2010, 9:10 p.m., <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good so far. But checkboxes are definitely the wrong control if only one can be selected. Is it possible to use radio buttons?
The mass selection sounds like a useful feature, although I'd have to see it in action to see if it can be understood.</pre>
</blockquote>
<p>On November 2nd, 2010, 8:23 a.m., <b>Stefan Derkits</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe another Idea would be to use no Colour. First, because it's hard to find Colours that look good in every Colour Scheme and second because a small percentage of Colour Blind Users can't see them. So maybe instead of using Colours, make an additional Collumn where you show the "Similarity Ratio" as a numerical Value. Does MusicDNS not support any kind of Information "how good the Results are"?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, in general I find color usage a good thing. However, as has been said, getting the colors right can be challenging.
Or maybe not? :) Right, Amarok will do it for you, automatically. We have a class that generates the best contrasting colors.
Check "PaletteHandler", I think that's the one.</pre>
<br />
<p>- Mark</p>
<br />
<p>On November 1st, 2010, 6:35 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-11-01 18:35:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rebuild MBT dialog. Now search result presented by a Tree, trackToSearch->SearchResults. Search results sorted by similarity ratio ( more similar is on top ), and has different colors corresponding to that. MusicDNS search results marked with a cyan color and stay on bottom. There is no Start search button any more, both searches run simultaneously.
Will be Implemented soon:
1) If one TrackID founded by both searches, this result automatically moves on top.
2) MB icon linked to track page on musicbrainz.org. //need to find a place for It
3..n Needs your advices. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(2abeca2)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: grey">(e33c9f6)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: grey">(cdc3ec5)</span></li>
<li>src/dialogs/MusicBrainzTagger.ui <span style="color: grey">(3f14236)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: grey">(49c8f6b)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(41ddbaa)</span></li>
<li>src/musicbrainz/MusicBrainzMeta.h <span style="color: grey">(57ed363)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: grey">(a93929a)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: grey">(1bf7389)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.h <span style="color: grey">(6eaa648)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.cpp <span style="color: grey">(fa1fc10)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: grey">(2cd00d1)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: grey">(9c31f38)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100127/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100127/s/10/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/01/MBT_400x100.png" style="border: 1px black solid;" alt="Refreshed view of MusicBrainz tagger" /></a>
<a href="http://git.reviewboard.kde.org/r/100127/s/11/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/11/01/MBT1_400x100.png" style="border: 1px black solid;" alt="Wide range diviation example, colors goes from red to green" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>