<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100107/">http://git.reviewboard.kde.org/r/100107/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 1st, 2010, 7:12 a.m., <b>Mark Kretschmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to work for me too. No issues so far. So apparently something might have been fixed upstream.
And tbh, I've started to lose track of all our various layout (QDockWidget) hacks. Removing them can only be a good thing.</pre>
</blockquote>
<p>On November 1st, 2010, 8:42 a.m., <b>Rick W. Chen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It'd be good to have someone test it on qt 4.6. I'd be able to do that myself in the next few days or so.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde 4.4 as well</pre>
<br />
<p>- Rick W.</p>
<br />
<p>On October 31st, 2010, 3:20 a.m., Rick W. Chen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Rick W. Chen.</div>
<p style="color: grey;"><i>Updated 2010-10-31 03:20:25</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes the dock resize hacks introduced in
8cb577dc891e13668098292f821f3a8131ced4b4, which was from the merge request
http://gitorious.org/amarok/amarok/merge_requests/154 .
There were dock resizing issues at the time, where the sizes and ratios of
different docks were not restored properly when maximizing and restarting
amarok. Now, at least with the new kde/qt dependencies I'm not experiencing
any problem of the sort.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with different dock arrangements:
- maximize and unmaximize window
- restart amarok
- hide and unhide window
The sizes and ratios of the docks remain the same.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.cpp <span style="color: grey">(9102558)</span></li>
<li>src/MainWindow.h <span style="color: grey">(4593d47)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100107/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>