<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100119/">http://git.reviewboard.kde.org/r/100119/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 31st, 2010, 4:52 p.m., <b>Leo Franchi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">look okay to me, will test with it in a bit.</pre>
</blockquote>
<p>On October 31st, 2010, 8:49 p.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Definitely not ship it. We should move all return types to QDateTime instead of the uint which is a left over form A1, instead of removing the one place where it is actually done properly.</pre>
</blockquote>
<p>On November 1st, 2010, 1:59 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also fine with me.
At least it's type safe this way.</pre>
</blockquote>
<p>On November 1st, 2010, 2:19 p.m., <b>Ian Monroe</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since there are thousands of Meta::Track's, seems like if a uint works we should just use that. Just looked at QDateTime, it has quite a few member variables.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I followed Maximilians proposal before reading Ian's comment.
QDateTimePrivate is not that bad and it's shared.
Also usually only a couple of hundred SqlMeta tracks are in memory at the same time.
On the other hand it improves type safety and I even noticed a copy and paste error (which wouldn't have happened with QDateTime in the first place).
Also an invalid date is much better represented.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On October 31st, 2010, 2:57 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated 2010-10-31 14:57:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes all instances of setYear( QString ) to setYear( int ) for better type safety.
Changes all instances of QDateTime Meta::Track::createDate() to uint Meta::Track::createDate() for better consistency with the other track dates which are already uints.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/browsers/CollectionTreeItemModelBase.cpp <span style="color: grey">(c25549b)</span></li>
<li>src/context/applets/albums/AlbumsModel.cpp <span style="color: grey">(9b376ff)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.h <span style="color: grey">(286cb3f)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp <span style="color: grey">(9a69079)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdMeta.h <span style="color: grey">(d5bb5a7)</span></li>
<li>src/core-impl/collections/audiocd/AudioCdMeta.cpp <span style="color: grey">(4255d00)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.h <span style="color: grey">(dcbb6ae)</span></li>
<li>src/core-impl/collections/daap/DaapMeta.cpp <span style="color: grey">(b8389b7)</span></li>
<li>src/core-impl/collections/daap/daapreader/Reader.h <span style="color: grey">(5c21caf)</span></li>
<li>src/core-impl/collections/daap/daapreader/Reader.cpp <span style="color: grey">(0fd70e5)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(7df9225)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(f3142e1)</span></li>
<li>src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp <span style="color: grey">(98fb5ba)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.cpp <span style="color: grey">(0520e8d)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.h <span style="color: grey">(e14d4d5)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.cpp <span style="color: grey">(7b3f302)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.h <span style="color: grey">(9fe8ef6)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(2008336)</span></li>
<li>src/core-impl/collections/sqlcollection/ArtistHelper.cpp <span style="color: grey">(1430df6)</span></li>
<li>src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp <span style="color: grey">(0e3578a)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: grey">(afdf937)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: grey">(b1a0694)</span></li>
<li>src/core-impl/collections/support/MemoryCollection.h <span style="color: grey">(2d5eebb)</span></li>
<li>src/core-impl/collections/support/MemoryFilter.cpp <span style="color: grey">(c076494)</span></li>
<li>src/core-impl/collections/support/MemoryMatcher.cpp <span style="color: grey">(bfcbd82)</span></li>
<li>src/core-impl/collections/umscollection/handler/UmsHandler.cpp <span style="color: grey">(1a5d2bb)</span></li>
<li>src/core-impl/collections/umscollection/podcasts/UmsPodcastMeta.h <span style="color: grey">(0f3b72d)</span></li>
<li>src/core-impl/collections/umscollection/podcasts/UmsPodcastMeta.cpp <span style="color: grey">(80a9523)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: grey">(81bfa04)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(9ab364b)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(70f2b91)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(e1af28e)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(3bae966)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(450cd6e)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy_p.h <span style="color: grey">(c581271)</span></li>
<li>src/core-impl/meta/stream/Stream.h <span style="color: grey">(cb45d3b)</span></li>
<li>src/core-impl/meta/stream/Stream.cpp <span style="color: grey">(c688053)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.h <span style="color: grey">(6fb0caa)</span></li>
<li>src/core-impl/meta/timecode/TimecodeMeta.cpp <span style="color: grey">(470283e)</span></li>
<li>src/core-impl/podcasts/sql/SqlPodcastMeta.cpp <span style="color: grey">(9a5b656)</span></li>
<li>src/core/capabilities/EditCapability.h <span style="color: grey">(ba91ef9)</span></li>
<li>src/core/collections/Collection.h <span style="color: grey">(a085f32)</span></li>
<li>src/core/meta/Meta.h <span style="color: grey">(35a4dc0)</span></li>
<li>src/core/meta/Meta.cpp <span style="color: grey">(e9c5089)</span></li>
<li>src/core/meta/support/MetaUtility.cpp <span style="color: grey">(534a61a)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(f0e671a)</span></li>
<li>src/dynamic/Bias.cpp <span style="color: grey">(6934a70)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: grey">(ab19ccc)</span></li>
<li>src/playlistgenerator/constraints/TagMatch.cpp <span style="color: grey">(a719825)</span></li>
<li>src/scriptengine/MetaTypeExporter.h <span style="color: grey">(fd9c96c)</span></li>
<li>src/scriptengine/MetaTypeExporter.cpp <span style="color: grey">(19e226e)</span></li>
<li>src/services/ServiceMetaBase.h <span style="color: grey">(72a7115)</span></li>
<li>src/services/ServiceMetaBase.cpp <span style="color: grey">(d267ade)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceCollection.cpp <span style="color: grey">(304f147)</span></li>
<li>src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp <span style="color: grey">(df6e47f)</span></li>
<li>tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp <span style="color: grey">(97e0281)</span></li>
<li>tests/core-impl/collections/sqlcollection/TestSqlTrack.cpp <span style="color: grey">(c4fa045)</span></li>
<li>tests/core-impl/meta/file/TestMetaFileTrack.cpp <span style="color: grey">(c921981)</span></li>
<li>tests/mocks/MetaMock.h <span style="color: grey">(d3c820c)</span></li>
<li>tests/mocks/MockTrack.h <span style="color: grey">(b799704)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100119/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>