<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100117/">http://git.reviewboard.kde.org/r/100117/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 31st, 2010, 2:59 p.m., <b>Leo Franchi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the applet! I'm testing it now... Inline comments below. One note: in the screenshot,the reload icon is at the top left. It would be better to put that in the top-right, so it's consistent with the other applets.</pre>
</blockquote>
<p>On October 31st, 2010, 5:09 p.m., <b>Rainer Sigle</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, I had the reload icon on the top right side first, but changed it due to recent updates in the context applets. If you look at wikipedia and labels applet, the icons are on the left side. Calender icon on Upcoming Events is also on left side. So it's not quite consistent throughout the applets. However I put it wherever you want... :-)</pre>
</blockquote>
<p>On October 31st, 2010, 5:14 p.m., <b>Leo Franchi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point. I guess we can leave it on the left for now...we should move all of them to the left then.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I plan to put the header into Context::Applet itself, the applets will just do setHeaderText(string) and addHeaderAction(action, left/right) and not worry about anything else.
At the moment if there are different number of actions on both sides the header text is slightly skewed from the centre. That's why I changed their positioning (especially the wikipedia on which had 5 on one side). I'll make it so that the text is centred no matter what and not change the appearance the applet author had intended.
But consistency is good.</pre>
<br />
<p>- Rick W.</p>
<br />
<p>On October 31st, 2010, 4:56 p.m., Rainer Sigle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Rainer Sigle.</div>
<p style="color: grey;"><i>Updated 2010-10-31 16:56:57</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new applet to the Amarok context menu: "Tabs". It's designed for guitar and bass-players, as it downloads and displays tablature information for the current song. Directly playing along a song has therefore never been easier.
The tab data is currently fetched from two sites: www.ultimateguitar.com and www.fretplay.com. As these provide no direct API, the tab data is extracted using some simple HTML parsing. Multiple results, e.g. versions of the tab, are stored and can be choosen from a list. A settings dialog allows to define the type of tabs to be fetched. In this patch we've guitar and bass, but it could be extended to e.g. drums or piano in the future. Furthermore I've added a reload button which allows to easily refine the criteria for the tab-search. This can be used e.g. when no tab-results were found because the song name contains fragments like (live), remix, etc.
I'll send some new png-images to amarok devel mailinglist because I was not able to correctly include these binary files into the patch. Please be aware that I don't know if there are any copyright restrictions on these bitmaps! Maybe they can be replaced with some KDE/Plasma specific images. Unfortunately I didn't find anything appropriate.
Thanks for any feedback on this...
By the way: Also big Thanks! to all Amarok devs and supporters for their great work. I love this application.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">used and tested during the last months, works fine for me</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/CMakeLists.txt <span style="color: grey">(98bdd2b)</span></li>
<li>src/context/applets/tabs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/ReloadEditDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsApplet.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsApplet.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsSettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/TabsView.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/amarok-context-applet-tabs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/amarok-tabs-bass.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/amarok-tabs-drum.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/amarok-tabs-guitar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/tabs/amarok-tabs-piano.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/engines/CMakeLists.txt <span style="color: grey">(c1f029e)</span></li>
<li>src/context/engines/tabs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/engines/tabs/TabsEngine.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/engines/tabs/TabsEngine.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/engines/tabs/TabsInfo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/engines/tabs/amarok-data-engine-tabs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100117/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100117/s/9/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/10/31/context_applet_tabs_400x100.png" style="border: 1px black solid;" alt="Tabs Applet" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>