<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100065/">http://git.reviewboard.kde.org/r/100065/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 25th, 2010, 4:53 p.m., <b>Ian Monroe</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey so basically this just needs some CMake tweaks (needs to not abort if it can't find the library) and then it can be pushed into master. Its a plugin so we can always disable it before the next release if its not ready.
I could make the cmake changes and push it. Is this on git somewhere?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Its on my gitorious, http://gitorious.org/~nikhilm/amarok/nikhilms-amarok/commits/upnp-collection
I would really like reviews on the code too, I'm not sure how many developers actually have a use for the UPnP collection.
Thanks for the CMake fixes.</pre>
<br />
<p>- Nikhil Shantanu</p>
<br />
<p>On October 17th, 2010, 11:30 a.m., Nikhil Shantanu Marathe wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Nikhil Shantanu Marathe.</div>
<p style="color: grey;"><i>Updated 2010-10-17 11:30:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds UPnP collection support.
1) Depends on the Cagibi SSDP daemon for discovery and the UPnP KIO slave (http://gitorious.org/kio-upnp-ms) for browse
2) Each upnp device is represented as a collection.
3) Tries to use search based collection to reduce memory usage and push complexity to the server. Falls back to MemoryCollection and simple browse when search is not supported
4) BrowseCollection performs a full scan using KIO::listDir
5) SearchCollection uses the slave and queues up jobs as required. The slave API is documented in the slave (controlpointthread.h)
Other than code feedback, I am not sure about certain build parameters
1) How do I check if the upnp kio slave is installed? Right now I'm checking for hupnp, but that probably isn't the right way
What is left:
* In certain cases, the CPU usage goes very high when running a full scan using BrowseCollection
* Needs some profiling
* Fix warnings</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with:
MediaTomb - browse based
Fuppes - search based
miniDLNA - search based (high quality)
There are issues with Windows Media Player's inbuilt upnp server. Some don't get accessed, and some don't stream their music at all. This may or may not be an upstream bug, or perhaps WMP's upnp is not standards compliant. Either way it requires investigation.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=145683">145683</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(baacef5)</span></li>
<li>cmake/modules/FindHUpnp.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/CMakeLists.txt <span style="color: grey">(1e29df7)</span></li>
<li>src/core-impl/collections/upnp/CMakeLists.txt <span style="color: grey">(441cd04)</span></li>
<li>src/core-impl/collections/upnp/amarok_collection-upnpcollection.desktop <span style="color: grey">(061b661)</span></li>
<li>src/core-impl/collections/upnpcollection/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionBase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionBase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMemoryQueryMaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMemoryQueryMaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQuery.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQuery.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpSearchCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/UpnpSearchCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/amarok_collection-upnpcollection.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/dbuscodec.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/dbuscodec.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/upnpcollection/deviceinfo.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100065/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>