<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100084/">http://git.reviewboard.kde.org/r/100084/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am still a little bit concerned about the changes to SqlMeta.cpp
The owner is not really needed as you can determine that from the uidUrl. It is also quite future proof.
Allowing multiple uids would be nice, but that is clearly out of this scope.
Also changing the album artist is a change that should be thought about.
I would rather move the track into a new album with the new album artist instead of changing the current album.
I just realized: Do you check if there is already another album with the same title and album artist?
For the rest of the MusicBrainz changes I trust in you. You are the expert.</pre>
<br />
<p>- Ralf</p>
<br />
<p>On October 24th, 2010, 7:07 a.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-10-24 07:07:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite (a bit) MusicBrainz tagger to use QVariantMap instead of specific classes to store tracks data. Search result threshold.
Add code for reading/writing MusicBrainz and AFT (used as default if no uid_owner specified) UIDs from/to MPC and MP4 files.
Add support of MPC and MP4 formats for AFTTagger utility.
Some try to handle "Album Artist" data (ability to store/load It in/from file). Support of updating/setting "Album Artist" for albums in SQLCollection.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested as I could. Works fine.
Found out that I have ~5 different "Best Of" albums of different artists, but not the only 1 as I thought before. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(45a9493)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.h <span style="color: grey">(c9f3e73)</span></li>
<li>src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp <span style="color: grey">(4bddd84)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(fa57e0a)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(f277a40)</span></li>
<li>src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp <span style="color: grey">(f800987)</span></li>
<li>src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp <span style="color: grey">(78fd02b)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.h <span style="color: grey">(b92e351)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: grey">(6b29b6e)</span></li>
<li>src/core-impl/meta/file/File.h <span style="color: grey">(c791ccd)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(b807cba)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(4f120a9)</span></li>
<li>src/core-impl/meta/file/TagLibUtils.cpp <span style="color: grey">(ad1a07e)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.h <span style="color: grey">(32f2f76)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(8cc01a1)</span></li>
<li>src/core/capabilities/EditCapability.h <span style="color: grey">(2406c1e)</span></li>
<li>src/core/meta/support/MetaConstants.h <span style="color: grey">(40cad34)</span></li>
<li>src/core/meta/support/MetaUtility.cpp <span style="color: grey">(0bb29db)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: grey">(d053e88)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: grey">(6f18606)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(4a0e94f)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: grey">(6fe3a47)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(f65e25d)</span></li>
<li>src/musicbrainz/MusicBrainzMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzMetaClasses.h <span style="color: grey">(b9f7d0c)</span></li>
<li>src/musicbrainz/MusicBrainzMetaClasses.cpp <span style="color: grey">(da83c16)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: grey">(cc1552e)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: grey">(f1dd54a)</span></li>
<li>src/musicbrainz/MusicBrainzTrackListModel.cpp <span style="color: grey">(442e662)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.h <span style="color: grey">(b0e9089)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.cpp <span style="color: grey">(b57baad)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: grey">(474c998)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: grey">(c026a8e)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.h <span style="color: grey">(a9b67e0)</span></li>
<li>tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp <span style="color: grey">(6fadb72)</span></li>
<li>tests/core-impl/collections/sqlcollection/TestAlbumCompilationChange.h <span style="color: grey">(daa35c0)</span></li>
<li>tests/core-impl/collections/sqlcollection/TestAlbumCompilationChange.cpp <span style="color: grey">(84a0164)</span></li>
<li>utilities/afttagger/AFTTagger.h <span style="color: grey">(8921875)</span></li>
<li>utilities/afttagger/AFTTagger.cpp <span style="color: grey">(2aa9aef)</span></li>
<li>utilities/collectionscanner/AFTUtility.cpp <span style="color: grey">(fde3bfa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100084/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>